Bug 237255 - astro/stellarium: fix build with GCC-based architectures
Summary: astro/stellarium: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-13 09:59 UTC by Piotr Kubaj
Modified: 2019-04-13 14:01 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments
patch (1.45 KB, patch)
2019-04-13 09:59 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (danfe)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-13 09:59:47 UTC
Created attachment 203636 [details]
patch

Add USES=compiler:c++11-lang and uncomment #include <sys/time.h> in src/external/libindi/libs/indibase/indilogger.h to fix build on GCC architectures.

GCC doesn't seem to include it by default.

Tested on powerpc64 and amd64.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-04-13 13:59:56 UTC
A commit references this bug:

Author: danfe
Date: Sat Apr 13 13:58:57 UTC 2019
New revision: 498808
URL: https://svnweb.freebsd.org/changeset/ports/498808

Log:
  - Fix the build on GCC-based architectures, e.g. PowerPC[64]
  - Drop no longer relevant CONFLICTS_INSTALL with Qt4 version
  - Don't remove -Wno-unused-result flag from CXXFLAGS: it was
    added as part of r363837 back in 2014 to appease a certain
    compiler version (I forgot which one), but today it is not
    needed anymore on any supported FreeBSD version

  PR:		237255
  Submitted by:	Piotr Kubaj

Changes:
  head/astro/stellarium/Makefile
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2019-04-13 14:01:42 UTC
Committed as ports r498808, but using sed(1) rather than the patch, thank you.