Bug 237298 - graphics/gdal fails to build with POPPLER option
Summary: graphics/gdal fails to build with POPPLER option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-15 11:56 UTC by Leon Dietrich
Modified: 2019-05-12 20:08 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
The build log by poudriere (884.89 KB, text/plain)
2019-04-15 11:56 UTC, Leon Dietrich 		no flags Details
gdal-2.4.1_1 fix build with poppler (5.97 KB, patch)
2019-05-08 19:02 UTC, Loïc Bartoletti 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leon Dietrich 2019-04-15 11:56:10 UTC 
Created attachment 203691 [details]
The build log by poudriere

Under certian conditions gdal fails to compile due to incompatible code. Please review the attached log for further details.
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2019-05-04 15:51:21 UTC 
pdfobject.cpp:1198:12: error: call to deleted constructor of 'Object'
    Object o = m_poDict->lookupNF(((char*)pszKey));
           ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/poppler/Object.h:197:3: note: 'Object' has been explicitly marked deleted here
  Object(const Object &other) = delete;
  ^
pdfobject.cpp:1332:12: error: call to deleted constructor of 'Object'
    Object o = m_poArray->getNF(nIndex);
           ^   ~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/poppler/Object.h:197:3: note: 'Object' has been explicitly marked deleted here
  Object(const Object &other) = delete;
  ^
2 errors generated.
Comment 2 Loïc Bartoletti freebsd_committer freebsd_triage 2019-05-08 12:52:42 UTC 
Seems to be an error with the conditional include of poppler version.

I will take a look
Comment 3 Loïc Bartoletti freebsd_committer freebsd_triage 2019-05-08 13:34:18 UTC 
There was an issue opened https://github.com/OSGeo/gdal/issues/1388 and fixed by this commit 
https://github.com/OSGeo/gdal/commit/5c12d11614a325317ceaa7c0567070b3e4188275
Comment 4 Loïc Bartoletti freebsd_committer freebsd_triage 2019-05-08 19:02:54 UTC 
Created attachment 204275 [details]
gdal-2.4.1_1 fix build with poppler

Fix build with poppler option enabled.
Patch from upstream
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-05-12 20:08:17 UTC 
Fixed in r501395. Thanks!