Bug 237408 - net-p2p/amule-devel: Fails to build with upnp 1.8.x
Summary: net-p2p/amule-devel: Fails to build with upnp 1.8.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Barbara Guida
URL: https://people.freebsd.org/~tobik/log...
Keywords:
Depends on:
Blocks: 234669
  Show dependency tree / graph
 
Reported: 2019-04-20 09:15 UTC by Tobias Kortkamp
Modified: 2019-04-22 06:36 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bar)

Attachments
amule-devel-upnp18.diff (21.86 KB, patch)
2019-04-20 14:21 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (bar)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-04-20 09:15:22 UTC 
Can you help fix it?

UPnPBase.cpp:843:3: error: static_cast from 'int (*)(Upnp_EventType, void *, void *)' (aka 'int (*)(Upnp_EventType_e, void *, void *)') to 'Upnp_FunPtr' (aka 'int (*)(Upnp_EventType_e, const void *, void *)') is not allowed
                static_cast<Upnp_FunPtr>(&CUPnPControlPoint::Callback),
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
UPnPBase.cpp:1155:14: error: member access into incomplete type 'struct Upnp_Discovery'
                if (d_event->ErrCode != UPNP_E_SUCCESS) {
                           ^
UPnPBase.cpp:1152:10: note: forward declaration of 'Upnp_Discovery'
                struct Upnp_Discovery *d_event = (struct Upnp_Discovery *)Event;
                       ^
UPnPBase.cpp:1156:38: error: member access into incomplete type 'struct Upnp_Discovery'
                        msg << UpnpGetErrorMessage(d_event->ErrCode) << ".";
                                                          ^
UPnPBase.cpp:1152:10: note: forward declaration of 'Upnp_Discovery'
                struct Upnp_Discovery *d_event = (struct Upnp_Discovery *)Event;
                       ^
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2019-04-20 14:21:52 UTC 
Created attachment 203829 [details]
amule-devel-upnp18.diff

Here's a patch that fixes the build with upnp 1.8 based on the upstream PR.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-04-22 06:36:49 UTC 
Fixed in ports r499599. Thank you!