Bug 237436 - java/openjdk8: configure fails when FONTCONFIG=off
Summary: java/openjdk8: configure fails when FONTCONFIG=off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-java (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2019-04-21 12:24 UTC by Dominik Lisiak
Modified: 2019-04-22 21:18 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (java)
koobs: merge-quarterly?


Attachments
openjdk8-8.212.4.1.log (32.18 KB, text/plain)
2019-04-21 12:24 UTC, Dominik Lisiak
no flags Details
patch file (936 bytes, patch)
2019-04-21 13:39 UTC, Dmitri Goutnik
dmgk: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Lisiak 2019-04-21 12:24:14 UTC
Created attachment 203860 [details]
openjdk8-8.212.4.1.log

The port fails to configure if FONTCONFIG option is disabled. If enabled it works fine. I have attached Poudriere log.
Comment 1 Dmitri Goutnik freebsd_committer 2019-04-21 13:39:10 UTC
Created attachment 203862 [details]
patch file

Looks like x11-fonts/fontconfig is always required and cannot depend on X11 knob.
Comment 2 Dmitri Goutnik freebsd_committer 2019-04-21 13:41:56 UTC
(In reply to Dominik Lisiak from comment #0)

FONTCONFIG implies X11 and x11-fonts/fontconfig currently depends on the X11, so configure fails without X11.
Comment 3 Fredrik Eriksson 2019-04-22 09:41:38 UTC
I also see this, and can also report that the port will build if either X11 or FONTCONFIG is set, so even if FONTCONFIG is off it can still build if X11 is on.
Comment 4 commit-hook freebsd_committer 2019-04-22 21:12:19 UTC
A commit references this bug:

Author: glewis
Date: Mon Apr 22 21:11:55 UTC 2019
New revision: 499687
URL: https://svnweb.freebsd.org/changeset/ports/499687

Log:
  Minor to whitespace to correct the PR for the previous commit.

  Previous commit was:

  Always depend on fontconfig

  PR:		237436
  Submitted by:   Dominik Lisiak <dominik.lisiak@bemsoft.pl>

Changes:
  head/java/openjdk8/Makefile
Comment 5 Greg Lewis freebsd_committer 2019-04-22 21:18:17 UTC
Note that attempting to disable fontconfig with configure will yield the message:

configure: error: It is not possible to disable the use of fontconfig.

I.e. it is now a requirement as of 8u212.

This makes the FONTCONFIG option confusing from a naming standpoint since fontconfig that will be a dependency even with the option off.

It might be worth removing the option and always making the additional source code changes in that option to avoid the confusion.