Bug 237439 - math/cln: unbreak on aarch64 (again)
Summary: math/cln: unbreak on aarch64 (again)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks: 201763
  Show dependency tree / graph
 
Reported: 2019-04-21 14:20 UTC by Val Packett
Modified: 2019-04-24 15:22 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (wen)

Attachments
cln.patch (3.58 KB, patch)
2019-04-21 14:20 UTC, Val Packett 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2019-04-21 14:20:04 UTC 
Created attachment 203863 [details]
cln.patch

I guess clang/LLVM/LLD got smarter recently — the out-of-namespace declaration is not preventing the symbol from being deleted anymore:

http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p498440_s346039/logs/errors/cln-1.3.4_1.log

Defining values does help, let's do that. (Makes more sense anyway, the out-of-namespace thing was a hack for MSVC…)
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-04-23 23:44:34 UTC 
A commit references this bug:

Author: wen
Date: Tue Apr 23 23:44:26 UTC 2019
New revision: 499801
URL: https://svnweb.freebsd.org/changeset/ports/499801

Log:
  - Unbreak on aarch64

  PR:		237439
  Submitted by:	greg@unrelenting.technology

Changes:
  head/math/cln/Makefile
  head/math/cln/files/extra-patch-src_base_cl__low.h
  head/math/cln/files/extra-patch-src_base_low_cl__low__div.cc
  head/math/cln/files/extra-patch-src_base_low_cl__low__mul.cc