Bug 237445 - usr.bin/procstat:procstat_test.kstacks broken on ^/stable/11 because of missing MFCs (r324619,r325906,etc)
Summary: usr.bin/procstat:procstat_test.kstacks broken on ^/stable/11 because of missi...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: 11.2-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: Enji Cooper
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-21 20:57 UTC by Enji Cooper
Modified: 2019-04-22 03:20 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2019-04-21 20:57:47 UTC
usr.bin/procstat:procstat_test.kstacks has been broken since it was MFCed to ^/stable/11 because of other missing MFCs in the branch related to command line argument handling. From https://ci.freebsd.org/job/FreeBSD-stable-11-amd64-test/4130/testReport/usr.bin.procstat/procstat_test/kernel_stacks/ :

Executing command [ procstat -a kstack ]

Standard Error

...

Fail: incorrect exit status: 64, expected: 0
stdout:

stderr:
usage: procstat [--libxo] [-CHhn] [-M core] [-N system] [-w interval]
                [-b | -c | -e | -f | -i | -j | -k | -l | -r | -s | 
                 -S | -t | -v | -x]
                [-a | pid | core ...]
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-04-22 03:19:49 UTC
A commit references this bug:

Author: ngie
Date: Mon Apr 22 03:19:41 UTC 2019
New revision: 346515
URL: https://svnweb.freebsd.org/changeset/base/346515

Log:
  Comment out checks that are causing failures on ^/stable/11, post-r337133

  Some usr.bin/procstat code has not been MFCed to ^/stable/11 for command line
  handling, and unfortunately, r337133 (which was MFCed as r337542) relies on
  that support.

  Comment out the checks and add a pointer to the PR for code archaeology and
  to cause future potential parties to verify changes when backporting them.

  This is a direct commit to ^/stable/11

  PR:		237445
  Reviewed by:	markj
  Approved by:	emaste (mentor; implicit)
  Differential Revision: https://reviews.freebsd.org/D19998

Changes:
  stable/11/usr.bin/procstat/tests/procstat_test.sh