Bug 237466 - remove fslsdma device from arm GENERIC file
Summary: remove fslsdma device from arm GENERIC file
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: arm (show other bugs)
Version: CURRENT
Hardware: arm Any
: --- Affects Many People
Assignee: freebsd-arm mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-04-22 12:12 UTC by MIHIRA Sanpei Yoshiro
Modified: 2019-05-02 13:33 UTC (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description MIHIRA Sanpei Yoshiro freebsd_committer 2019-04-22 12:12:04 UTC
armのGENERIC kernelにある、driver fslsdmaですが、firmware loader(sys/arm/freescale/imx/files.imx6のoptional sdma_fw )必要なのにGENERIC kernelに入っていないです。
(armのGENERICに入れるときに忘れたみたい)

firmware fileもライセンスの関係(Linux方面でだれか質問したけどライセンスの回答がきていない)のでsource treeに入れられないみたいなので。fslsdmaは消したほうが良いと思うのですが、



--- sys/arm/conf/GENERIC        (revision 346440)
+++ sys/arm/conf/GENERIC        (working copy)
@@ -252,7 +252,6 @@
 device         ti_mbox

 # DMA controller
-device         fslsdma
 device         ti_sdma
 device         a10_dmac
 device         a31_dmac
Comment 1 MIHIRA Sanpei Yoshiro freebsd_committer 2019-04-22 12:21:10 UTC
(In reply to MIHIRA Sanpei Yoshiro from comment #0)

Sorry I missed to create this bug rerport.

fslsdms device in arm GENERIC needs firmware loader(sys/arm/freescale/imx/files.imx6 optional sdma_fw). But the current GENERIC file does not have sdma_fw. (I think it was forgotten to add it).

We could not import firmware for fslsdms into source tree(because there is no LICENSE information). 

So I think we remove fslsdms from arm GENERIC file.

--- sys/arm/conf/GENERIC        (revision 346440)
+++ sys/arm/conf/GENERIC        (working copy)
@@ -252,7 +252,6 @@
 device         ti_mbox

 # DMA controller
-device         fslsdma
 device         ti_sdma
 device         a10_dmac
 device         a31_dmac
Comment 2 Warner Losh freebsd_committer 2019-04-22 15:19:06 UTC
Here's my translation of the Japanese into English (assisted a bit by Google, but Google's translation was terrible so I fixed it, I think).

----
The fslsdma driver is in arm's GENERIC kernel config. However, it also requires the firmware loader (optional sdma_fw) which is not included. It may have been forgotten when GENERIC was created.

There are licensing issues with the firmware needed to make this work. Enquiries with people using Linux have not resolved the issue, so the firmware can't be put into FreeBSD's source tree.

Therefore, I think that it is better to just delete fslsdma from GENERIC.
-----
The attached patch does delete fslsdma from GENERIC. Thank you for the report sanpei-san.
Comment 3 Warner Losh freebsd_committer 2019-04-22 15:20:16 UTC
(looks like sanpai-san added a better translation between when I noticed the bug report and did the translation myself... Sorry for the duplication)
Comment 4 Ian Lepore freebsd_committer 2019-04-27 14:55:29 UTC
I belive we can import the firmware, I found enabling licensing info here:

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=3123d78e09d2f815de4d94aa35c07b3c0469c80e

It looks to me to be basically a BSD license with some modifications to forbid deecompiling or reverse-engineering.

I started on the work to import the firmware, then got sidetracked by other projects and haven't gotten back to it yet.
Comment 5 Warner Losh freebsd_committer 2019-04-29 14:11:20 UTC
We should remove it until the firmware import is ready, imho.