Bug 237539 - [patch] emulators/virtualbox-ose: add USES=sdl
Summary: [patch] emulators/virtualbox-ose: add USES=sdl
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jung-uk Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-24 22:06 UTC by Samy Mahmoudi
Modified: 2019-04-24 23:09 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (vbox)


Attachments
Patch file generated with svn diff (1.44 KB, patch)
2019-04-24 22:06 UTC, Samy Mahmoudi
no flags Details | Diff
Patch file generated with svn diff (308 bytes, patch)
2019-04-24 22:13 UTC, Samy Mahmoudi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samy Mahmoudi 2019-04-24 22:06:24 UTC
Created attachment 203985 [details]
Patch file generated with svn diff

Using USE_SDL alone is deprecated, please add USES=sdl.

Reference: https://reviews.freebsd.org/D19075
Comment 1 Samy Mahmoudi 2019-04-24 22:13:24 UTC
Created attachment 203986 [details]
Patch file generated with svn diff

I first uploaded an irrelevant patch by mistake. The last patch is the right one.
Comment 2 Jung-uk Kim freebsd_committer 2019-04-24 23:06:31 UTC
I'll take it.
Comment 3 Jung-uk Kim freebsd_committer 2019-04-24 23:09:33 UTC
Committed, thanks!
Comment 4 commit-hook freebsd_committer 2019-04-24 23:09:53 UTC
A commit references this bug:

Author: jkim
Date: Wed Apr 24 23:09:01 UTC 2019
New revision: 499919
URL: https://svnweb.freebsd.org/changeset/ports/499919

Log:
  Add USES=sdl when USE_SDL=sdl is set.  No functional change.

  PR:		237539

Changes:
  head/emulators/virtualbox-ose/Makefile