Bug 237545 - [patch][maintainer] update net/onedrive to 2.3.3
Summary: [patch][maintainer] update net/onedrive to 2.3.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-25 04:51 UTC by Hiroo Ono
Modified: 2019-04-28 15:35 UTC (History)
1 user (show)

See Also:


Attachments
onedrive freeclient port update 1.1.3 -> 2.3.3 (7.86 KB, patch)
2019-04-25 04:51 UTC, Hiroo Ono
no flags Details | Diff
onedrive freeclient port update 1.1.3 -> 2.3.3 (9.13 KB, patch)
2019-04-28 14:26 UTC, Hiroo Ono
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroo Ono 2019-04-25 04:51:32 UTC
Created attachment 203997 [details]
onedrive freeclient port update 1.1.3 -> 2.3.3

jeskynar informed me in bug #236573,comment #5 that onedrive freeclient repository was superceded by https://github.com/abraunegg/onedrive .
Update to version 2.3.3 in this repository.
Comment 1 Kurt Jaeger freebsd_committer 2019-04-28 14:10:22 UTC
It fails to build with this error:

ldc2 -w -g -ofonedrive -O  -L-lcurl -L-lsqlite3 -L-linotify -L-ldl -J. src/config.d src/itemdb.d src/log.d src/main.d src/monitor.d src/onedrive.d src/qxor.d src/selective.d src/sqlite.d src/sync.d src/upload.d src/util.d src/progress.d src/freebsd_inotify.d
src/progress.d(29): Error: undefined identifier `TIOCGWINSZ`
gmake[1]: *** [Makefile:91: onedrive] Error 1
gmake[1]: Leaving directory '/wrkdirs/usr/ports/net/onedrive/work/onedrive-2.3.3'

TIOCGWINSZ can be found in /usr/include/sys/ttycom.h:

#define  TIOCGWINSZ      _IOR('t', 104, struct winsize)  /* get window size */

but I'm unsure how it can be used in dlang. Can you check ?
Comment 2 Hiroo Ono 2019-04-28 14:26:09 UTC
Created attachment 204084 [details]
onedrive freeclient port update 1.1.3 -> 2.3.3

Sorry I forgot to svn add one patch file.
Added patch add enum TIOCGWINSZ to progress.d.

Proper fix would be to convert /usr/include/sys/ioccom.h and ttycom.h for D language, already pulled by upstream ( https://github.com/dlang/druntime/pull/2582 ).
Comment 3 Kurt Jaeger freebsd_committer 2019-04-28 14:54:03 UTC
testbuild@work
Comment 4 Kurt Jaeger freebsd_committer 2019-04-28 15:35:06 UTC
Thanks, testbuilds are fine now.

Committed!
Comment 5 commit-hook freebsd_committer 2019-04-28 15:35:31 UTC
A commit references this bug:

Author: pi
Date: Sun Apr 28 15:35:04 UTC 2019
New revision: 500320
URL: https://svnweb.freebsd.org/changeset/ports/500320

Log:
  net/onedrive: upgrade 1.1.3 -> 2.3.3

  - MASTERSITE moved

  PR:		237545
  Submitted by:	Hiroo Ono <hiroo.ono+freebsd@gmail.com> (maintainer)
  Relnotes:	https://github.com/abraunegg/onedrive/releases
  		https://github.com/abraunegg/onedrive/blob/master/CHANGELOG.md

Changes:
  head/net/onedrive/Makefile
  head/net/onedrive/distinfo
_U  head/net/onedrive/files/freebsd_inotify.d
  head/net/onedrive/files/patch-Makefile
  head/net/onedrive/files/patch-src_monitor.d
  head/net/onedrive/files/patch-src_progress.d
  head/net/onedrive/files/version
  head/net/onedrive/pkg-plist