Bug 237584 - games/0ad: adds missing USES flags, removes implicit dependency on csh
Summary: games/0ad: adds missing USES flags, removes implicit dependency on csh
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-26 17:08 UTC by Lorenzo Salvadore
Modified: 2019-04-28 15:10 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+


Attachments
0ad - USES flags and csh patch (1.86 KB, patch)
2019-04-26 17:08 UTC, Lorenzo Salvadore
phascolarctos: maintainer-approval? (madpilot)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore 2019-04-26 17:08:52 UTC
Created attachment 204043 [details]
0ad - USES flags and csh patch

0ad uses gl, gnome and sdl: it should be declared in the USES variable. My patch adds the missing USES flags.

The file files/patch-libraries_sources_fcollada_src_Makefile introduces a dependency on csh. It is true that csh is in the base system, however some users (such as myself) compile their base system with WITHOUT_TCSH=yes: those users does not have csh and can not build the port. My patch modifies the file with an sh-compatible solution, so that the dependency is not needed any more.
Comment 1 Guido Falsi freebsd_committer 2019-04-26 20:03:59 UTC
(In reply to Lorenzo Salvadore from comment #0)
> Created attachment 204043 [details]
> 0ad - USES flags and csh patch
> 

Thanks for the patch!

> 0ad uses gl, gnome and sdl: it should be declared in the USES variable. My
> patch adds the missing USES flags.

Good catch!

> 
> The file files/patch-libraries_sources_fcollada_src_Makefile introduces a
> dependency on csh. It is true that csh is in the base system, however some
> users (such as myself) compile their base system with WITHOUT_TCSH=yes:
> those users does not have csh and can not build the port. My patch modifies
> the file with an sh-compatible solution, so that the dependency is not
> needed any more.

I added that code to remove the dependency on bash, and csh provided an easy way to do that. As you observed it's in base so I thought it was a non issue.

Anyway your patch looks ok at first glance, let me test it a little and I'll see to commit it.
Comment 2 commit-hook freebsd_committer 2019-04-28 15:10:09 UTC
A commit references this bug:

Author: madpilot
Date: Sun Apr 28 15:09:44 UTC 2019
New revision: 500318
URL: https://svnweb.freebsd.org/changeset/ports/500318

Log:
  - Modify patch to not implicitly depend on csh during build.
  - Add some missing USES

  PR:		237584
  Submitted by:	Lorenzo Salvadore <phascolarctos@protonmail.ch>

Changes:
  head/games/0ad/Makefile
  head/games/0ad/files/patch-libraries_source_fcollada_src_Makefile
Comment 3 Guido Falsi freebsd_committer 2019-04-28 15:10:35 UTC
Committed. Thanks!