Bug 237626 - x11/lightdm-gtk-greeter: fix build with GCC-based architectures
Summary: x11/lightdm-gtk-greeter: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ben Woods
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-28 15:47 UTC by Piotr Kubaj
Modified: 2019-04-30 14:27 UTC (History)
1 user (show)

See Also:
woodsb02: maintainer-feedback+

Attachments
patch (358 bytes, patch)
2019-04-28 15:47 UTC, Piotr Kubaj 		woodsb02: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-28 15:47:06 UTC 
Created attachment 204087 [details]
patch

Add USE_CSTD=c99 to fix:
lightdm-gtk-greeter.c: In function 'start_authentication':
lightdm-gtk-greeter.c:2023: error: 'for' loop initial declaration used outside C99 mode

Happens when building with base GCC.

Tested on powerpc64 and amd64.
Comment 1 Ben Woods freebsd_committer freebsd_triage 2019-04-28 22:43:57 UTC 
Comment on attachment 204087 [details]
patch

Looks good to me, please feel free to commit this change Piotr.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-04-30 14:27:14 UTC 
A commit references this bug:

Author: pkubaj
Date: Tue Apr 30 14:26:32 UTC 2019
New revision: 500496
URL: https://svnweb.freebsd.org/changeset/ports/500496

Log:
  x11/lightdm-gtk-greeter: fix build with GCC-based architectures

  Add USE_CSTD=c99 to fix:
  lightdm-gtk-greeter.c: In function 'start_authentication':
  lightdm-gtk-greeter.c:2023: error: 'for' loop initial declaration used outside C99 mode

  PR:		237626
  Approved by:	woodsb02 (maintainer), mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D20094

Changes:
  head/x11/lightdm-gtk-greeter/Makefile