Created attachment 204091 [details]
py-zeek-pkg shell archive
The Bro Package Manager has been renamed to the Zeek Package Manager. The SVN diff in the bug includes the deprecation of the py-bro-pkg and the attached shell archive is for version 1.7.1 of the Zeek Package manager. Because everything will be renamed eventually, it is better to do this now and update the port in the process.
The pkg-message file still mentions "bro-pkg" as the created python scripts still have not been updated. This will change at some point in the future and will be patched when upstream renames the python script to "zeek-pkg"
--- py-bro-pkg/Makefile (revision 500354)
+++ py-bro-pkg/Makefile (working copy)
@@ -3,7 +3,7 @@
CATEGORIES= security python
@@ -18,6 +18,9 @@
+DEPRECATED= Bro package manager has been renamed to Zeek package manager
USE_PYTHON= distutils autoplist concurrent
I should have added this is a maintainer update, so let me know if this needs to be split into two separate bugs.
@Shirkdog Thank you for the issue detail.
This should likely take the form of a "port move" via 'svn mv', then updating the target to be the new name, instead of a deprecation && new port.
- Include all changes for the above move as an svn diff against /usr/ports instead of in comments, including an entry in MOVED for the port rename
- Use the maintainer-approval attachment flag (set to +), to signify maintainer approval. Attachment -> Details -> maintainer-approval [+].
Created attachment 204965 [details]
py-zeek-pkg shell archive updated
Created attachment 204966 [details]
svn diff for move
Created attachment 205054 [details]
Created attachment 205055 [details]
(In reply to Shirkdog from comment #1)
Thank you for your updated patches. I looked at it and the overall picture is clear, but we need to do a small change with the package name.
If you take a look at PyPi you'll see that the Python package name is "zkg" and the release has been updated to 2.0.0 recently.
I have attached two patches (SVN version + shar archive) that reflects those changes. With the 2.0.0 release one can use "zkg" instead of "bro-pkg" to fetch packages but "bro-pkg" can still be used for backwards compatibility.
To summarize all changes:
- Port is renamed from "security/py-bro-pkg" to "security/py-zkg"
- Update to 2.0.0
- Update the pkg-descr accordingly (and align the text somewhat to make it more readable)
- Also update the pkg-message with a hint about the previously used command "bro-pkg"
If those changes are ok for you, I'll commit them together with the other required changes (update MOVED and security/Makefile, etc.).
@Kai diffs are fine for port moves
Let's also obsolete any .. obsoleted patches and please include the MOVED and category/Makefile updates with it as well. And issue summary needs updating
Created attachment 205057 [details]
Attached the complete diff and one more addition that I forgot to mention before:
I also added "git:devel/git" to the RUN_DEPENDS otherwise "zkg" / "bro-pkg" throws an exception / warning during runtime:
> Traceback (most recent call last):
> File "/usr/local/lib/python3.6/site-packages/git/__init__.py", line 83, in <module>
> File "/usr/local/lib/python3.6/site-packages/git/__init__.py", line 73, in refresh
> if not Git.refresh(path=path):
> File "/usr/local/lib/python3.6/site-packages/git/cmd.py", line 290, in refresh
> raise ImportError(err)
> ImportError: Bad git executable.
> The git executable must be specified in one of the following ways:
> - be included in your $PATH
> - be set via $GIT_PYTHON_GIT_EXECUTABLE
> - explicitly set via git.refresh()
> All git commands will error until this is rectified.