Bug 237712 - lang/tcl87 improvements
Summary: lang/tcl87 improvements
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-tcltk (Nobody)
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2019-05-02 18:49 UTC by Mikhail Teterin
Modified: 2019-05-03 08:10 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (tcltk)


Attachments
Do the needful (687 bytes, patch)
2019-05-02 18:49 UTC, Mikhail Teterin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer 2019-05-02 18:49:15 UTC
Created attachment 204168 [details]
Do the needful

The attached patch improves the port thus:

. Do not even extract the compat/ subdirectory - to ensure, its content is not used at compile time
. Do not strip binaries, when DEBUG-option is set

In addition, I'd also like to convert the port to using math/libtommath instead of compiling its own version. However, I see some TomMath-related hunks in the files/patch-unix_Makefile.in. Has anyone looked into using the tommath-port already -- as the [Porter's Handbook says](https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/bundled-libs.html)

The same - or very similar can/should be done to lang/tcl86.
Comment 1 commit-hook freebsd_committer 2019-05-03 08:08:18 UTC
A commit references this bug:

Author: gahr
Date: Fri May  3 08:07:57 UTC 2019
New revision: 500703
URL: https://svnweb.freebsd.org/changeset/ports/500703

Log:
  lang/tcl87: do not strip in debug mode

  PR:		237712
  Submitted by:	mi@

Changes:
  head/lang/tcl87/Makefile
Comment 2 Pietro Cerutti freebsd_committer 2019-05-03 08:10:44 UTC
Regarding libtommath, I think core Tcl bundles a slightly modified version of upstream libtommath. I would rather not take the decision to link against vanilla upstream independently from core Tcl.