Bug 237753 - base system build fails if WITHOUT_INET6=yes due to unused variable in nfsdumpstate.c
Summary: base system build fails if WITHOUT_INET6=yes due to unused variable in nfsdum...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 12.0-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Rick Macklem
URL:
Keywords: ipv6, toolchain
Depends on:
Blocks:
 
Reported: 2019-05-05 10:09 UTC by Lorenzo Salvadore
Modified: 2019-05-06 03:50 UTC (History)
1 user (show)

See Also:
rmacklem: mfc-stable12+
rmacklem: mfc-stable11+
rmacklem: mfc-stable10+


Attachments
nfsdumpstate.c - define nbuf only if INET6 is defined (631 bytes, patch)
2019-05-05 10:09 UTC, Lorenzo Salvadore
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer 2019-05-05 10:09:45 UTC
Created attachment 204224 [details]
nfsdumpstate.c - define nbuf only if INET6 is defined

If WITHOUT_INET6 is set to "yes" the base system build fails due to an unused variable into nsfdumpstate.c (char nbuf[INET6_ADDRSTRLEN]), which is defined in two different functions: I propose a patch that declares the variable only if INET6 is defined.

I tested successfully with 12.0-Stable r347145.
Comment 1 Andrey V. Elsukov freebsd_committer 2019-05-05 10:17:55 UTC
This is already fixed in head/ in r346856 and will be merged into stable/12 soon.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-05-05 10:20:13 UTC
This looks to be resolved (in head) in base r346856 by rmacklem, marked for MFC (1 week)

Leave In Progress until MFC is complete. Not sure if this applies to stable/11 (have requested with ?), set flag to - if it doesn't apply.
Comment 3 Lorenzo Salvadore freebsd_committer 2019-05-05 10:24:26 UTC
Oh, sorry. I should have checked better. Will do next time. Thanks.
Comment 4 Rick Macklem freebsd_committer 2019-05-06 03:44:47 UTC
The patch has been MFC'd.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2019-05-06 03:50:10 UTC
MFC stable/10 in base r347174
MFC stable/11 in base r347172
MFC stable/12 in base r347171

@Rick Thanks for that! If you could include PR: references in MFC's as well that will ensure they are tracked (and linked) in Bugzilla comments instead of having to manually do it