Bug 237781 - ports-mgmt/portlint: whines about IGNORE within .if blocks, even though the IGNORE works there
Summary: ports-mgmt/portlint: whines about IGNORE within .if blocks, even though the I...
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-08 01:40 UTC by Larry Rosenman
Modified: 2019-06-30 19:07 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Larry Rosenman freebsd_committer freebsd_triage 2019-05-08 01:40:58 UTC 
I ran portlint against the current sysutils/lsof Makefile, and portlint complains:

⌂115% [ler@borg.lerctr.org:/usr/ports/sysutils/lsof] $ portlint
WARN: Makefile: "IGNORE" has to appear earlier.
0 fatal errors and 1 warning found.
⌂106% [ler@borg.lerctr.org:/usr/ports/sysutils/lsof] $

No matter where I put the .if block, it complains.  If I put it before the
.include <bsd.port.pre.mk>
line, the check fails in poudriere.

As far as I know, the IGNORE doesn't have to be moved for this case (I'm not sure of the exact rules, but this warning is INCORRECT).
Comment 1 Larry Rosenman freebsd_committer freebsd_triage 2019-06-30 18:38:58 UTC 
Anything?  Anyone?
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2019-06-30 19:07:05 UTC 
Sorry, I never saw the original email.  In this case, use "IGNORE+=" to set IGNORE late, and portlint will not complain.  The result will be the same.