Bug 237782 - [NEW PORT] games/py-lolcat: Port of games/rubygem-lolcat: cat(1), but with rainbows and unicorns
Summary: [NEW PORT] games/py-lolcat: Port of games/rubygem-lolcat: cat(1), but with ra...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2019-05-08 03:04 UTC by Trix Farrar
Modified: 2019-07-03 12:22 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (trix)


Attachments
Shell archive for port games/py-lolcat (1.87 KB, text/plain)
2019-05-08 03:04 UTC, Trix Farrar
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Trix Farrar 2019-05-08 03:04:10 UTC
Created attachment 204252 [details]
Shell archive for port games/py-lolcat

It's like cat(1) but with unicorns and rainbows.  A Python3port of
games/rubygem-lolcat (with no dependencies beyond lang/python3).

WWW: https://github.com/basementtrix/lolcat
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-05-08 04:53:26 UTC
Thanks for your new port contribution Trix

The port needs to be renamed, as it conflicts with existing registered 'lolcat' package in PyPI [1], which is also a port of the ruby package

Additional review items:

- Don't pin USES=python to a specific version unles it *only* supports that version. Instead declare versions it supports, if this is *needs* any 3.x version, 3.5+ is ok,  

- I don't believe this will pass portlint at the moment, at least: USE_* section not in USE/USES section, and LICENCE_* section out of order.

Please run this through portlint and poudriere to confirm QA passing

[1] https://pypi.org/project/lolcat/
Comment 2 Trix Farrar 2019-05-08 13:31:12 UTC
I wasn't sure about how to use the USES_PYTHON variable.  Thank you for the pointer.

It does pass portlint and I did build it with poudriere:

$ portlint py-lolcat
WARN: Makefile: Consider defining LICENSE.
0 fatal errors and 1 warning found.
$ 

(not sure how to get past that warning since the license in the script is "unique".)

I am aware of the PyPI project, but don't know if pip wraps packages the way CPAN does (or did?) for Perl.  My repository is actually forked from the PyPI  project's github repository.  The project hasn't had a release since 2016-06-07 and currently has year-old PRs outstanding. I have e-mailed the author.

In the meantime, I have no problems re-naming the port to avoid conflict.  Should that work continue on this PR or should this one be closed and a new one opened under the new name?
Comment 3 Trix Farrar 2019-05-08 14:19:30 UTC
FWIW: E-mail to the original author "Wijnand Modderman-Lenstra"<maze@pyth0n.org> is returned with "reason: 554 5.7.1 <maze@pyth0n.org>: Relay access denied"
Comment 4 Trix Farrar 2019-07-03 12:22:37 UTC
Plan to open new PR for new name, after some code re-factoring.