Bug 237893 - Manpage pcap-filter(7) missing
Summary: Manpage pcap-filter(7) missing
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Hans Petter Selasky
URL:
Keywords: needs-qa, patch-ready, regression
Depends on:
Blocks:
 
Reported: 2019-05-14 11:44 UTC by Martin Beran
Modified: 2019-12-25 09:30 UTC (History)
9 users (show)

See Also:


Attachments
/usr/src/lib/libpcap/Makefile (1.12 KB, patch)
2019-05-27 21:50 UTC, Andrew Stevenson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Beran 2019-05-14 11:44:14 UTC
Manpage pcap-filter(7) is not installed on FreeBSD 12.0. It is referenced by tcpdump(1) and was present in FreeBSD 11.2-p4, but disappeared after binary upgrade to 12.0. It is missing on both my 12.0 machines.
Comment 1 Andrew Stevenson 2019-05-27 21:49:35 UTC
It was this commit that stopped it being installed I think: https://github.com/freebsd/freebsd/commit/30f165e2d74c681f9df978d1f8f6eeef4569babb#diff-f47145dbca3572dd06e3bab12d4f176b

There are a few other pages that don't get installed. It's trivial to add them back - but I don't know if they were removed for a reason?

I attach a patch that adds in the man pages the libpcap distribution appears to install but the base system Makefile doesn't. They all seem of interest to libpcap users to me. I have also expanded the sed line to expand more macros found in the man pages.
Comment 2 Andrew Stevenson 2019-05-27 21:50:32 UTC
Created attachment 204657 [details]
/usr/src/lib/libpcap/Makefile
Comment 3 Poul-Henning Kamp freebsd_committer 2019-12-14 17:14:34 UTC
I can confirm this is also missing on 13.0-current r355131 installed from sources
Comment 4 Kyle Evans freebsd_committer 2019-12-14 17:29:09 UTC
Assign to committer of r334277; patch looks good to me.
Comment 5 Hans Petter Selasky freebsd_committer 2019-12-14 22:28:28 UTC
I'll have a look at this on Monday.

Patch basically looks OK.

--HPS
Comment 6 Kyle Evans freebsd_committer 2019-12-15 16:40:59 UTC
(In reply to Hans Petter Selasky from comment #5)

Thanks, Hans!
Comment 7 commit-hook freebsd_committer 2019-12-16 09:11:50 UTC
A commit references this bug:

Author: hselasky
Date: Mon Dec 16 09:11:39 UTC 2019
New revision: 355800
URL: https://svnweb.freebsd.org/changeset/base/355800

Log:
  Install missing pcap(3) manual pages and add missing manpage
  section substitutions.

  Submitted by:	Martin Beran <martin@mber.cz>
  PR:		237893
  MFC after:	1 week
  Sponsored by:	Mellanox Technologies

Changes:
  head/lib/libpcap/Makefile
Comment 8 commit-hook freebsd_committer 2019-12-25 09:28:20 UTC
A commit references this bug:

Author: hselasky
Date: Wed Dec 25 09:28:07 UTC 2019
New revision: 356070
URL: https://svnweb.freebsd.org/changeset/base/356070

Log:
  MFC r355800:
  Install missing pcap(3) manual pages and add missing manpage
  section substitutions.

  Submitted by:	Martin Beran <martin@mber.cz>
  PR:		237893
  Sponsored by:	Mellanox Technologies

Changes:
_U  stable/12/
  stable/12/lib/libpcap/Makefile
Comment 9 commit-hook freebsd_committer 2019-12-25 09:30:24 UTC
A commit references this bug:

Author: hselasky
Date: Wed Dec 25 09:30:10 UTC 2019
New revision: 356071
URL: https://svnweb.freebsd.org/changeset/base/356071

Log:
  MFC r355800:
  Install missing pcap(3) manual pages and add missing manpage
  section substitutions.

  Submitted by:	Martin Beran <martin@mber.cz>
  PR:		237893
  Sponsored by:	Mellanox Technologies

Changes:
_U  stable/11/
  stable/11/lib/libpcap/Makefile