Created attachment 204379 [details]
wazuh is a fork of ossec. This is a port for the agent itself.
I added a patch for no detecting FreeBSD as it would a startup command into rc.local.
There is no configure style component, only an interactive install.sh script which can be automated via preloaded vars (also patched).
As this is my second maintained port better look twice if everything is ok :)
I'll take it.
Created attachment 205371 [details]
I updated the port to 3.9.2, removed unused patches, cleaned all critical warnings from portlint -A and also poudriere error are gone.
Tested the compiled port fine here on a FreeBSD 11.2.
Some review items/questions:
1) Why does this fetch dependency tarballs and build using those rather than depending on and building against port versions?
2) Is it possible to use environment variables, passed into MAKE_ENV (or otherwise, to set/configure the various build/install variables in etc/preloaded-vars.conf instead of hardcoding them?
If not, it might still be worth instead, echo'ing the appropriate lines into the file, rather than patching it. This would mean that configuration lives in the port Makefile rather than a patch, and changing those configuration directives, manually or dynamically later, much easier
3) Having all the packages files live under its own single directory in /var/ossec is not appropriate for the vast majority of ports. Ports/packages should be installed respecting hier(7) (see man7 heir)
Note: (1) and (3) are pretty important issues fundamental to the way we port things.
Thanks for taking the time to review!
1) Wazuh sadly uses patched versions so they offer their own ones.
2) I need a second look at this, Wazuh uses a big blob install.sh script and I took most logic out of it to don't get stage violations. Maybe the patch can also be removed completely since the guided install script isn't used.
3) Wazuh is a fork of ossec and most of the scripts uses hardcoded path's. In my first shar I tried to implement via /usr/local/wazuh but most of the scripts inside wont work. There's also a ticket at GH but progress is slow: https://github.com/wazuh/wazuh/issues/785
(In reply to Michael Muenz from comment #5)
My pleasure Michael,
On balance, given ossec is in the tree with the same issues, I suppose we can give this a pass, but at least for (3) we may want to put it in /usr/local/<foo> where other ports/packages that have the same issue put their hierarchies. At least its then consistently inconsistent.
Lastly, we'll want to let upstream know in as encouraging terms as possible that it would be great to be able to easily put different things (bin files, docs, run time data, configuration) in different places, and dynamically modify the build (though we can get by with echo'ing build parameters to a file for now)
Created attachment 205389 [details]
wazuh 3.9.2 cleanup
I deleted all patches since install.sh isn't called anymore, they are not needed. In addition I added second copy job for ossec.conf.sample. Regarding 3) I'm constantly talking to the dev's via Slack Channel. I know, not the best method to share knowledge, not a fan of this thing. If you have an account there I can share you the link or send a screenshot of discussion (when needed).
Thanks for your time!