Bug 238019 - [PATCH] x11-wm/hikari: added desktop file so that hikari can be started form a login manager
Summary: [PATCH] x11-wm/hikari: added desktop file so that hikari can be started form ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-21 11:46 UTC by Alexander Sieg
Modified: 2019-08-24 23:58 UTC (History)
4 users (show)

See Also:

Attachments
patch file (1.20 KB, patch)
2019-05-21 11:46 UTC, Alexander Sieg 		no flags Details | Diff
patch with the desktop file (1.50 KB, patch)
2019-05-21 14:00 UTC, Alexander Sieg 		no flags Details | Diff
desktop entry patch (444 bytes, patch)
2019-05-24 08:28 UTC, Max Brazhnikov 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Sieg 2019-05-21 11:46:13 UTC 
Created attachment 204506 [details]
patch file
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2019-05-21 13:34:59 UTC 
I think you missed the actual .desktop file in the patch :)
Comment 2 Alexander Sieg 2019-05-21 14:00:36 UTC 
Created attachment 204512 [details]
patch with the desktop file
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-05-21 21:24:16 UTC 
A commit references this bug:

Author: 0mp
Date: Tue May 21 21:24:03 UTC 2019
New revision: 502236
URL: https://svnweb.freebsd.org/changeset/ports/502236

Log:
  Add hikari.desktop for display/login managers.

  While here:
  - Include bsd.port.pre.mk before checking the value of WITH_DEBUG so that
    WITH_DEBUG_PORTS is respected.
  - Mention that the format of config.h may change across versions.

  PR:		238019
  Submitted by:	Alexander Sieg <alex@xanderio.de>

Changes:
  head/x11-wm/hikari/Makefile
  head/x11-wm/hikari/files/
  head/x11-wm/hikari/files/hikari.desktop.in
Comment 4 Max Brazhnikov freebsd_committer freebsd_triage 2019-05-24 08:28:08 UTC 
Created attachment 204588 [details]
desktop entry patch

Couple of tweaks for desktop entry:
- Change its type to Xsession similar to other WMs
- Use full path to executable
Comment 5 Hayato Kawajiri 2019-06-29 02:46:28 UTC 
MARKED AS SPAM
Comment 6 Walter Schwarzenfeld freebsd_triage 2019-08-15 10:37:59 UTC 
Forgotten to close?