Bug 238054 - www/otter-browser: fix build on non-x86
Summary: www/otter-browser: fix build on non-x86
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-22 19:46 UTC by Piotr Kubaj
Modified: 2019-05-23 12:38 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments
patch (457 bytes, patch)
2019-05-22 19:46 UTC, Piotr Kubaj
tcberner: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-05-22 19:46:52 UTC
Created attachment 204548 [details]
patch

Some architectures don't have qt5-webengine available, use it only on i386 and amd64.
Comment 1 Tobias C. Berner freebsd_committer 2019-05-23 04:12:28 UTC
Looks good to me.

mfg Tobias
Comment 2 Piotr Kubaj freebsd_committer 2019-05-23 07:20:44 UTC
(In reply to Tobias C. Berner from comment #1)
Just to be clear, does it require a separate DR?
Comment 3 Tobias C. Berner freebsd_committer 2019-05-23 10:50:45 UTC
(In reply to Piotr Kubaj from comment #2)
No, just commit it :)
Comment 4 commit-hook freebsd_committer 2019-05-23 12:38:15 UTC
A commit references this bug:

Author: pkubaj
Date: Thu May 23 12:37:44 UTC 2019
New revision: 502339
URL: https://svnweb.freebsd.org/changeset/ports/502339

Log:
  www/otter-browser: use qt5-webengine only on amd64 and i386

  This makes this port build by default on other architectures.

  PR:		238054
  Approved by:	tcberner (mentor)

Changes:
  head/www/otter-browser/Makefile