Bug 238087 - www/firefox: update to 68.0 (currently, Beta phase)
Summary: www/firefox: update to 68.0 (currently, Beta phase)
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gecko mailing list
URL: https://wiki.mozilla.org/Releases/Fir...
Keywords: needs-qa, patch
Depends on: 236651 237677
Blocks:
  Show dependency treegraph
 
Reported: 2019-05-23 22:56 UTC by Jan Beich
Modified: 2019-05-26 08:44 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gecko)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2019-05-23 22:56:25 UTC
See review D20391 for the patch.
Comment 1 Jan Beich freebsd_committer 2019-05-25 11:56:05 UTC
Mikaël, can you check build on aarch64? This version will move to www/firefox-esr around 2019-09-03, so it'd be nice if upstream has fixes as well.
Comment 2 mikael.urankar 2019-05-25 14:38:32 UTC
One error in the configure phase (I don't upgrade my ports very often):
ERROR: cbindgen version 0.8.3 is too old. At least version 0.8.7 is required

I'm not familiar with gecko.mk, maybe this patch should do it:
--- bsd.gecko.mk        (revision 502573)
+++ bsd.gecko.mk        (working copy)
@@ -111,7 +111,7 @@
 .endif
 
 .if ${MOZILLA_VER:R:R} >= 63
-BUILD_DEPENDS+=        rust-cbindgen>=0.6.8:devel/rust-cbindgen \
+BUILD_DEPENDS+=        rust-cbindgen>=0.8.7:devel/rust-cbindgen \
                                node:www/node
 .endif
Comment 3 Jan Beich freebsd_committer 2019-05-25 16:34:19 UTC
(In reply to mikael.urankar from comment #2)
Thanks. Applied in ports r502585 as cbindgen version was incorrect even for Firefox 67.0.
Comment 4 mikael.urankar 2019-05-26 08:44:39 UTC
(In reply to Jan Beich from comment #1)
it's ok on aarch64