Bug 238139 - finance/bitcoinnodestats: Wrong use of USES=shebangfix
Summary: finance/bitcoinnodestats: Wrong use of USES=shebangfix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kai Knoblich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-26 12:13 UTC by Tobias Kortkamp
Modified: 2019-05-27 05:46 UTC (History)
0 users

See Also:
kai: maintainer-feedback+
kai: merge-quarterly-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2019-05-26 12:13:42 UTC
The port sets SHEBANGFILES which has no semantic meaning in the framework.
Probably SHEBANG_FILES was meant here.  Also I wonder if the scripts
shouldn't be installed with INSTALL_SCRIPT?  Then we would also get proper
QA errors like:

====> Running Q/A tests (stage-qa)
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'share/bitcoinnodestats/create_local_settings.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'share/bitcoinnodestats/manage.py'
*** Error code 1

Can you please fix it?  Thank you.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-05-26 12:18:33 UTC
@Tobias This change proposal is a blanket (approval) candidate under:

Approved by: portmgr (blanket: framework compliance)
Approved by: portmgr (blanket: just fix it)
Comment 2 Kai Knoblich freebsd_committer 2019-05-26 12:45:15 UTC
(In reply to Tobias Kortkamp from comment #0)

Thank you for discovering a silly typo. I'm on it and a fix with a MFH will follow shortly.
Comment 3 commit-hook freebsd_committer 2019-05-26 13:10:59 UTC
A commit references this bug:

Author: kai
Date: Sun May 26 13:10:29 UTC 2019
New revision: 502714
URL: https://svnweb.freebsd.org/changeset/ports/502714

Log:
  finance/bitcoinnodestats: Fix wrong use of USES=shebangfix

  * Spell SHEBANG_FILES correctly
  * Install the scripts with INSTALL_SCRIPT instead of INSTALL_DATA to get
    proper QA results.

  PR:		238139
  Reported by:	tobik
  MFH:		2019Q2

Changes:
  head/finance/bitcoinnodestats/Makefile
Comment 4 Kai Knoblich freebsd_committer 2019-05-26 14:48:56 UTC
(In reply to Kubilay Kocak from comment #1)

A MFH is not possible because finance/bitcoinnodestats was added to the ports tree shortly after the 2019Q2 branch.
Comment 5 Kai Knoblich freebsd_committer 2019-05-26 14:50:12 UTC
Committed, thank you for reporting this issue!
Comment 6 Tobias Kortkamp freebsd_committer 2019-05-26 15:08:17 UTC
Thanks for the help.