Bug 238162 - math/cvc4: Remove llvm60 build dependency
Summary: math/cvc4: Remove llvm60 build dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2019-05-27 06:05 UTC by Tobias Kortkamp
Modified: 2019-05-27 10:11 UTC (History)
1 user (show)

See Also:
val: maintainer-feedback+
koobs: merge-quarterly?

Attachments
cvc4.diff (746 bytes, patch)
2019-05-27 06:05 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (val)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-05-27 06:05:07 UTC 
Created attachment 204642 [details]
cvc4.diff

Can we please get rid of the llvm60 build dependency?  FreeBSD 10 is no longer
supported and it builds fine on 11.2/i386, 12.0/amd64, 13.0/amd64 without it.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-05-27 06:08:48 UTC 
I believe this is a blanket candidate not requiring approval, given EoL status of 10.x. Presumably the dependency ought to have been scoped to only FreeBSD 10.x OSVERSIONS in the first instance.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-05-27 06:29:06 UTC 
(In reply to Kubilay Kocak from comment #1)
> I believe this is a blanket candidate not requiring approval, given EoL
> status of 10.x. Presumably the dependency ought to have been scoped to only
> FreeBSD 10.x OSVERSIONS in the first instance.

I'm basing this on the comment above it and comments left in ports are often
wrong or are not updated to new circumstances, so let's ask Greg to confirm
that this is ok.

Also the comment above LLVM_VERSION is quite useless as it does not explain
what the build failure was in any detail whatsoever.
Comment 3 Val Packett 2019-05-27 09:57:44 UTC 
The failure was: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229780#c1

This looks fine, I didn't even care about i386. Thanks for reminding me about this port, there's a new version out, I'll post an update soon.
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2019-05-27 10:10:40 UTC 
Thanks.
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-05-27 10:11:02 UTC 
A commit references this bug:

Author: tobik
Date: Mon May 27 10:10:15 UTC 2019
New revision: 502779
URL: https://svnweb.freebsd.org/changeset/ports/502779

Log:
  math/cvc4: Remove llvm60 build dependency

  It was added for FreeBSD 10.x/i386 and is no longer needed.

  PR:		238162
  Approved by:	greg@unrelenting.technology (maintainer)

Changes:
  head/math/cvc4/Makefile