Description Alexey Dokuchaev 2019-05-27 09:29:39 UTC

PVS Studio reports: /usr/src/sys/kern/kern_conf.c:627:1: warning: V649 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains function return. This means that the second 'if' statement is senseless. Check lines: 616, 627.

>        if (devsw->d_flags & D_INIT)
>                return (0);
         if (devsw->d_flags & D_NEEDGIANT) {
                 dev_unlock();
                 dsw2 = malloc(sizeof *dsw2, M_DEVT,
                      (flags & MAKEDEV_NOWAIT) ? M_NOWAIT : M_WAITOK);
                 dev_lock();
                 if (dsw2 == NULL && !(devsw->d_flags & D_INIT))
                         return (ENOMEM);
         } else
                 dsw2 = NULL;
>        if (devsw->d_flags & D_INIT) {
>                if (dsw2 != NULL)
>                        cdevsw_free_devlocked(dsw2);
>                return (0);
         }

This code appeared in base r177301.