Bug 238195 - net-mgmt/super_mediator: Fails to package when MYSQL=OFF
Summary: net-mgmt/super_mediator: Fails to package when MYSQL=OFF
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Garrett Wollman
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2019-05-28 17:05 UTC by Garrett Wollman
Modified: 2019-06-03 01:43 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (nacho319+freebsdZilla)
koobs: merge-quarterly?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Garrett Wollman freebsd_committer 2019-05-28 17:05:12 UTC
The packing list includes super_table_creator unconditionally, but it is only built if mysql support is configured.

Trivial patch (beware whitespace lossage):

Index: Makefile
===================================================================
--- Makefile    (revision 501580)
+++ Makefile    (working copy)
@@ -21,6 +21,7 @@
 USE_GNOME=     glib20
 
 PLIST_SUB+=    PORTVERSION="${PORTVERSION}"
+OPTIONS_SUB=   yes
 
 OPTIONS_DEFINE=        SPREAD MYSQL SKIPSET
 OPTIONS_DEFAULT=       MYSQL SKIPSET
Index: pkg-plist
===================================================================
--- pkg-plist   (revision 501580)
+++ pkg-plist   (working copy)
@@ -1,6 +1,6 @@
 man/man1/super_mediator.conf.1.gz
 man/man1/super_table_creator.1.gz
 man/man1/super_mediator.1.gz
-bin/super_table_creator
+%%MYSQL%%bin/super_table_creator
 bin/super_mediator
 @sample etc/super_mediator.conf.sample
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-05-29 09:57:07 UTC
Reporter is committer, assign accordingly.

This change is:

Approved by: portmgr (blanket: packaging fix)

I'd have set maintainer-approval on the patch if it was attached
Comment 2 Garrett Wollman freebsd_committer 2019-06-03 01:43:49 UTC
(In reply to Kubilay Kocak from comment #1)
I haven't been a ports committer in many years and I'm totally out of touch with current procedures.