Created attachment 204728 [details]
I'm going to update the asterisk13 and asterisk16 ports.
These new versions made changes to an include file used by your port.
Some defines have been moved from app.h to a new mwi.h file.
Upstream repo has a commit addressing this 
Attaching a patch importing that patch.
This is an informative PR since I can commit this with "fixit" blanket approval.
I'm still doping final testing of the asterisk update though.
It would be better to just update the chan-sccp version/revision number, instead of fixing the source. Newer versions of chan-sccp already have this fixed/patched.
I will create new v4.3.2-delta tag this week, so that we only have to update the
GH_TAGNAME, all the rest is already include.
Thanks for bringing this to my attention.
(In reply to Diederik de Groot from comment #2)
> I will create new v4.3.2-delta tag this week, so that we only have to update
> GH_TAGNAME, all the rest is already include.
> Thanks for bringing this to my attention.
I'll commit anyway the source patch with the asterisk update, to avoid breaking the port.
Once you have the new tag please CC me with your bug report so i can take it and perform the update.
I will do that. Thanks a lot.
(In reply to Diederik de Groot from comment #4)
> @Guido Falsi
> I will do that. Thanks a lot.
It would be a good idea to move from options to flavors to support more asterisk versions, so that packages will be built for all asterisk versions.
You can use the other asterisk channel drivers as reference, for example net/asterisk-g72x.
Such a change will require explicit portmgr approval, but I think it would be worth the wait.
I will look into flavors, thanks for the reference.
A commit references this bug:
Date: Fri May 31 07:44:49 UTC 2019
New revision: 503120
Fix build after asterisk13 and asterisk16 update.
Approved by: blanket
Obtained from: https://github.com/chan-sccp/chan-sccp/commit/9684efb7709c1be23c99f555f61b5a3ad15b0675
Created attachment 205094 [details]
Update to 4.3.2_delta
Update version to 4.3.2_delta
Use Flavors instead of options to choose the asterisk version
@Guido: Not sure if you wanted me to upload the new patch here, or open a new bugreport. So please let me know.
(In reply to Diederik de Groot from comment #9)
For some reason I did not notice or forgot this bug report. Sorry for the mistake.
I'll have a look at this in the next few days.
adding flavors requires portmgr approval, so I filed a code review:
Is there a way to make this process go any faster ?
I'm adding portmgr@ as CC to this bug.
This bug is submitted as a code review, and requires portmgr approval due to it adding flavors to a port.
Can someone fro portmgr review it?
Thanks in advance.
I also updated the review so that it applies cleanly to the ports tree.
Thank you !
A commit references this bug:
Date: Sun Nov 24 10:10:31 UTC 2019
New revision: 518311
- Update asterisk-chan_sccp to 4.3.2_delta
- Convert asterisk version OPTIONS to FLAVORS
Submitted by: Diederik de Groot <firstname.lastname@example.org> (maintainer)
Approved by: portmgr (mat)
Differential Revision: https://reviews.freebsd.org/D21485
(In reply to commit-hook from comment #16)