Bug 238256 - games/freeciv: Remove games/ggz-gtk-client dependency and unlock on 13.0
Summary: games/freeciv: Remove games/ggz-gtk-client dependency and unlock on 13.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-05-31 07:50 UTC by Tobias Kortkamp
Modified: 2019-06-15 07:43 UTC (History)
1 user (show)

See Also:
tobik: maintainer-feedback? (johans)


Attachments
freeciv.diff (1.38 KB, patch)
2019-05-31 07:50 UTC, Tobias Kortkamp
tobik: maintainer-approval? (johans)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2019-05-31 07:50:04 UTC
Created attachment 204732 [details]
freeciv.diff

games/ggz-gtk-client currently fails to build on 13.0 [1] which means
games/freeciv is skipped as well.  But the dependency on it seems to be
optional and we can just remove it to unlock Freeciv on 13.0.

I suspect that games/ggz-gtk-client in general is no longer functional as
it has not been updated since 2008. There are also no new commits since 2011
in the upstream repo.

Also requesting maintainership of games/freeciv while here.

Poudriere test builds ok on 11.2/i386 and 13.0/amd64.

[1] http://beefy12.nyi.freebsd.org/data/head-amd64-default/p502843_s348318/logs/errors/ggz-gtk-client-0.0.14.1_9.log
Comment 1 commit-hook freebsd_committer 2019-06-15 07:42:51 UTC
A commit references this bug:

Author: tobik
Date: Sat Jun 15 07:42:42 UTC 2019
New revision: 504231
URL: https://svnweb.freebsd.org/changeset/ports/504231

Log:
  games/freeciv: Remove games/ggz-gtk-client dependency and unlock build on 13.0

  ggz-gtk-client currently fails to build on 13.0.  ggz-gtk-client
  seems to be abandoned upstream and fixing it might not be worthwhile.
  Freeciv does not really need it, so remove the dependency on it.

  Also take maintainership.

  PR:		238256
  Approved by:	johans (maintainer timeout, 2 weeks)

Changes:
  head/games/freeciv/Makefile