Bug 238261 - multimedia/vlc: Fix undeclared dependencies
Summary: multimedia/vlc: Fix undeclared dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2019-05-31 13:00 UTC by Lorenzo Salvadore
Modified: 2019-06-20 16:32 UTC (History)
2 users (show)

See Also:
riggs: maintainer-feedback+
riggs: merge-quarterly+


Attachments
vlc - fixes undeclared dependencies (3.90 KB, patch)
2019-05-31 13:00 UTC, Lorenzo Salvadore
phascolarctos: maintainer-approval? (multimedia)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore 2019-05-31 13:00:55 UTC
Created attachment 204740 [details]
vlc - fixes undeclared dependencies

Compiling the port with DEVELOPER=yes revealed some implicit dependencies. Using poudriere I tried to spot all of them and fix them. Here is a short description of the patch:

- Adds security/libgpg-error and textproc/libebml to LIB_DEPENDS.
- Defines three new options -- GSTREAMER, JPEG, OGGSPOTS -- enabled by default. Those are necessary because otherwise the configure script will automatically choose if enabling the corresponding features or not, making dependencies difficult to track.
- Adds USE_GNOME=cairo when LIBSVG2 is on or NOTIFY is on.
- Adds SDL_USES=sdl since USE_SDL alone is deprecated.
- Adds dependency on audio/speexdsp when SPEEX is on.
- Adds VDPAU_USE= XORG=sm,ice,x11.
- Bumps PORTREVISION.

Tested successfully with poudriere on 12.0-RELEASE amd64, but since the port has many options and my macchine is slow, I could not test all cases and I suggest to test it more.
Comment 1 commit-hook freebsd_committer 2019-06-20 16:02:03 UTC
A commit references this bug:

Author: riggs
Date: Thu Jun 20 16:01:00 UTC 2019
New revision: 504636
URL: https://svnweb.freebsd.org/changeset/ports/504636

Log:
  Update to upstream release 3.0.7.1; Makefile fixes

  Details:
  - Update to newest upstream release 3.0.7.1
  - Fix drive-by dependencies, reported in [1]
  - Introduce new options for JPEG and OGGSPOTS [1]

  PR:		238261 [1]
  Reported by:	phascolarctos@protonmail.ch [1]
  MFH:		2019Q2

Changes:
  head/multimedia/vlc/Makefile
  head/multimedia/vlc/distinfo
  head/multimedia/vlc/files/patch-modules_codec_vpx.c
  head/multimedia/vlc/pkg-plist
Comment 2 commit-hook freebsd_committer 2019-06-20 16:29:33 UTC
A commit references this bug:

Author: riggs
Date: Thu Jun 20 16:29:10 UTC 2019
New revision: 504644
URL: https://svnweb.freebsd.org/changeset/ports/504644

Log:
  MFH: r504636

  Update to upstream release 3.0.7.1; Makefile fixes

  Details:
  - Update to newest upstream release 3.0.7.1
  - Fix drive-by dependencies, reported in [1]
  - Introduce new options for JPEG and OGGSPOTS [1]

  PR:		238261 [1]
  Reported by:	phascolarctos@protonmail.ch [1]

  Approved by:	ports-secteam (riggs)

Changes:
_U  branches/2019Q2/
  branches/2019Q2/multimedia/vlc/Makefile
  branches/2019Q2/multimedia/vlc/distinfo
  branches/2019Q2/multimedia/vlc/files/patch-modules_codec_vpx.c
  branches/2019Q2/multimedia/vlc/pkg-plist
Comment 3 Thomas Zander freebsd_committer 2019-06-20 16:32:20 UTC
Committed a variant with the vlc update in r504636. (Transitive dependencies, e.g. speexdsp are not necessary, since speex cannot live without it)
Thank you!