Bug 238381 - [patch] ports-mgmt/pkg periodic/security/410.pkg-audit gives verbose output
Summary: [patch] ports-mgmt/pkg periodic/security/410.pkg-audit gives verbose output
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: freebsd-pkg (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-07 10:54 UTC by Mike Clarke
Modified: 2020-09-22 21:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (pkg)

Attachments
Change ${security_status_pkgaudit_quiet:-YES} to ${security_status_pkgaudit_quiet:=YES} in 410.pkg-audit (451 bytes, patch)
2019-06-07 10:54 UTC, Mike Clarke 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Clarke 2019-06-07 10:54:42 UTC 
Created attachment 204873 [details]
Change ${security_status_pkgaudit_quiet:-YES} to ${security_status_pkgaudit_quiet:=YES} in 410.pkg-audit

periodic/security fails to use default -q option and gives verbose display when reporting packages with security vulnerabilities
Comment 1 Baptiste Daroussin freebsd_committer 2019-06-07 12:11:12 UTC 
fixed in git, will be in the next release, thank you!
Comment 2 Matt Simerson 2020-09-22 21:06:56 UTC 
In a very related (verbose output), how about not spitting out empty jail names when they have no output? Here's a little patch demonstrating it.

    for j in $jails ; do
        output=''
        for t in audit expiration deprecation; do
            output=${output}$(${t}_pkgs "-j ${j%|*}" ${j##*|})
            last_rc=$?
            [ $last_rc -gt 1 ] && rc=$last_rc
        done

        if [ -n "$output" ]; then
            echo
            echo "jail: ${j%|*}"
            echo $output
        fi
    done

Thanks for your consideration.