Bug 238387 - audio/zam-plugins-lv2: Discuss existing patches to port to absorb upstream
Summary: audio/zam-plugins-lv2: Discuss existing patches to port to absorb upstream
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-07 13:01 UTC by Damien
Modified: 2019-06-07 16:54 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Damien 2019-06-07 13:01:54 UTC
Hi,

I wish to ask a few questions regarding the existing patches for this port so I can understand what I need to change upstream to absorb the patches where possible.

I noticed: `-Wl,--as-needed` is removed from the linker flags.  Is that something bsd specific or should I remove it everywhere for all builds?

`-ldl` is removed, perhaps I don't even need that flag in DPF (?)

I need to ask falktx to fix the getwd() call to be more platform independent.

Cheers,
Damien
Comment 1 Yuri Victorovich freebsd_committer 2019-06-07 16:54:35 UTC
(In reply to Damien from comment #0)

> `-Wl,--as-needed` is removed from the linker flags.

-Wl,--as-needed is for very special situations when some symbol is missing and is resolved by the user. It should not be needed in LV2 plugins.

> `-ldl` is removed

This used to be BSD-specific, buy I think that they added libdl.so on FreeBSD too. Please don't worry about this.


Yuri