Created attachment 204895 [details] update patch CockroachDB will be relicensed beginning with 19.2: https://www.cockroachlabs.com/blog/oss-relicensing-cockroachdb/ The version we carry is too old and its likely people may want to keep using the fully opensourced version for a while so update to the latest. For the time being, build with GCC as RocksDB doesn't build with Clang 8. Hopefully upstream will produce a patch we can merge.
Forgot to mention: I haven't tested this beyond compilation. It should be reviewed by maintainer (or someone that actually uses it, if maintainer times out) and hopefully we can get the clang issue fixed before committing.
I'm afraid we cannot commit untested patches. If there's nobody interested in run-testing this, I'll have to close the issue.
I can. Wait a while.
(In reply to Dmitry Marakasov from comment #2) In all honesty the existing port is so old that if it not updated we should deprecate the port altogether. (Thanks Kirill for testing!)
Created attachment 222863 [details] Fresh port version I've updated the port to the latest version of cockroachdb and tested it.
(In reply to Kirill from comment #5) 1) diffs are usualy better to review the changes. 2) What is the license of the latest version? (just wondering)
(In reply to Pedro F. Giffuni from comment #6) 1) I will consider. 2) This is a difficult topic https://www.cockroachlabs.com/docs/stable/licensing-faqs.html
(In reply to Kirill from comment #7) The licensing is a good reason to keep the port at 19.1, at at least for a while: CockroachDB version License Converts to Apache 2.0 20.2 Business Source License Nov 10, 2023 20.1 Business Source License May 12, 2023 19.2 Business Source License Oct 01, 2022 19.1 Apache 2.0 -
Created attachment 222907 [details] patch-19.1.11 Version 19.1.1 contains a build bug. Everything is fine with 19.1.11. The patch is in the attachment.
Comment on attachment 204895 [details] update patch Obsoleted by 19.1.11 (which I recommend committing).
ping (?): the maintainer obviously timed out on this, if the Assignee has no time I can take over.
Committed, thanks! I've also reset the maintainer; Pedro, Kirill, feel free to take over.
(In reply to Dmitry Marakasov from comment #12) Thanks so much Dmitry! I don't really use this at all, I just thought we should keep a copy of the latest fully-free version. If Kirill feels so inclined, we could have a -devel port with the latest version, but for me this is enough.