Created attachment 204960 [details]
Update graphics/py-traitsui from 6.0.0 to 6.1.1.
Created attachment 206194 [details]
An update of graphics/py-traitsui to 6.1.2 has been released.
Created attachment 206416 [details]
(In reply to vladimir.chukharev from comment #1)
thanks for the update to 6.1.2 and sorry for the delay. I did some additional QA and attached is a new patch that has some fixed RUN_DEPENDS and options for the extra dependencies.
All those dependencies are defined in "traitsui/__init__.py" and are obtained via setup.py from there.
If you're fine with that patch I'll commit it as soon as possible.
Thanks for adding the options. I was starting to work on it, but that goes too slowly. What bothers me a bit with your patch is that portlint complains:
$ portlint -Ca
FATAL: Makefile: : OPTIONS_GROUP_TOOLKITS is set after including bsd.port.pre.mk.
WARN: Makefile: WXGTK appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE.
FATAL: Makefile: extra item "RUN_DEPENDS" placed in the LICENSE section.
Moreover, Porters Handbook warns that after an inclusion of bsd.port.pre.mk some USE_* flags will not work as expected, and something like "WXGTK_USE=wxgtk=3.0+" is recommended instead (184.108.40.206. Syntax; Example 5.41. Practical Use of OPTIONS).
I'm still struggling with the options usage, so hardly I can correct the patch fast enough. I believe you can do it better.
As to dependecies, pyface already has them. I think, it's better to minimize the dependence lists by avoiding their duplications. Am I wrong?
What do you think about moving this discussion to phabricator?
(In reply to vladimir.chukharev from comment #4)
Thank you for your feedback and indeed, I'm aware about the warnings that portlint gives. ;)
One warning can be reduced by removing the comment above of the RUN_DEPENDS.
The warning about WXGTK that isn't listed in OPTIONS_DEFINE occurs because the WXGTK option isn't available for non-py27 flavors. If you do e.g.
> $ FLAVOR=py27 portlint -AC
the output will differ somewhat. I've to admit that the current options usage is quite a hack and similar done as for the www/py-autobahn port.
I would have added the patch to Phabricator either way and if you like, I would prepare the review and add you as subscriber?
(In reply to Kai Knoblich from comment #5)
Yes, add me as a subscriber of the diff, please!
Created attachment 206951 [details]
Attached is the latest version of the revised patch from D21229 to be in sync with Bugzilla/Phabricator.
Comment on attachment 206951 [details]
Great job! And thanks a lot for all your explanations here and in Phabricator!
A commit references this bug:
Date: Tue Aug 27 20:07:40 UTC 2019
New revision: 510023
graphics/py-traitsui: Update to 6.1.2
* Enable build for all Python versions as the support for Python 3 has been
added since the 5.0.0 release.
* Introduce new default option QT5  to let the port make use of the Qt5
toolkit. (Support for the wxPython toolkit is also available but was left
out intentionally because it isn't available for Python 3, yet.)
* Also add a "do-test" target to make future QA easier while I'm here.
Changelog since 6.0.0:
Submitted by: firstname.lastname@example.org (maintainer)
Reviewed by: koobs (Python)
Approved by: email@example.com (maintainer) 
Differential Revision: https://reviews.freebsd.org/D21229
(In reply to vladimir.chukharev from comment #8)
Committed, thank you for the patch and the great collaboration here and on Phabricator!
P.S.: I just did a minor change in the comment regarding the options -> s/wxWidgets/wxPython/ as wxWidgets is still in v3.x. Just for the sake of completeness.