Bug 238522 - textproc/libxslt: fix bug preventing OpenOffice build
Summary: textproc/libxslt: fix bug preventing OpenOffice build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome mailing list
URL: https://gitlab.gnome.org/GNOME/libxml...
Keywords:
Depends on:
Blocks: 235713
  Show dependency treegraph
 
Reported: 2019-06-12 13:30 UTC by Steve Wills
Modified: 2019-06-13 13:05 UTC (History)
1 user (show)

See Also:
kwm: maintainer-feedback+


Attachments
patch to add fix to port and bump portrevision (1.49 KB, patch)
2019-06-12 13:30 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer 2019-06-12 13:30:43 UTC
Created attachment 205006 [details]
patch to add fix to port and bump portrevision

There's a bug in libxslt which causes OpenOffice to fail to build when using the libxml2 2.9.9 (or later, presumably).

Attached is a patch which fixes the issue.

For more information, see:

https://gitlab.gnome.org/GNOME/libxml2/issues/66
https://gitlab.gnome.org/GNOME/libxslt/commit/5b0965010abf274f7a3a1291d16dde34c167e8a7

Not sure if this is going to need an exp-run or not. Note this fix isn't in libxslt 1.1.33, so we'll need to maintain the patch until a version with the fix is released, probably 1.1.34 if I had to guess.
Comment 1 Koop Mast freebsd_committer 2019-06-12 15:14:34 UTC
These ports don't see many changes, also the releases are really slow. Just add the upstream patch in with a link to upstream gitlab/bugreport.
Comment 2 commit-hook freebsd_committer 2019-06-13 12:59:57 UTC
A commit references this bug:

Author: swills
Date: Thu Jun 13 12:59:40 UTC 2019
New revision: 504090
URL: https://svnweb.freebsd.org/changeset/ports/504090

Log:
  textproc/libxml2: Update to 2.9.9 [1]

  While here, fix a bug in libxslt triggered by the libxml2 update

  PR:		235713 [1]
  PR:		238522
  Exp-run by:	antoine
  Reported by:	kunda <chitty_cloud@me.com> [1]
  Reviewed by:	kwm [1] [2]
  Obtained from:	https://gitlab.gnome.org/GNOME/libxslt/commit/5b0965010abf274f7a3a1291d16dde34c167e8a7

Changes:
  head/textproc/libxml2/Makefile
  head/textproc/libxml2/distinfo
  head/textproc/libxslt/Makefile
  head/textproc/libxslt/files/patch-libxslt-keys.c
  head/textproc/py-libxml2/Makefile
Comment 3 Steve Wills freebsd_committer 2019-06-13 13:05:16 UTC
Fix committed