Bug 238535 - devel/py-hgsubversion: unbreak with mercurial 5.0
Summary: devel/py-hgsubversion: unbreak with mercurial 5.0
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-python (Nobody)
URL: https://bitbucket.org/durin42/hgsubve...
Keywords: easy, patch-ready, regression
Depends on:
Reported: 2019-06-13 04:28 UTC by Charlie Li
Modified: 2020-03-08 09:35 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (python)

py-hgsubversion-hg5.0.patch (22.67 KB, patch)
2019-06-13 04:28 UTC, Charlie Li
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Li 2019-06-13 04:28:58 UTC
Created attachment 205025 [details]

Mercurial 5.0 introduced some breaking API changes that this extension depends on. This patch pulls in all revisions between the 1.9.3 release and tip as of this writing (6a6ce9d), since there were, again, multiple API breakages.

Been dogfooding this since devel/mercurial updated to 5.0; passes testport, portlint and runtime.
Comment 1 Sunpoet Po-Chuan Hsieh freebsd_committer 2019-06-15 19:24:21 UTC
It seems 6a6ce9d is the only thing required for mercurial 5.0 fix.
Comment 2 Charlie Li 2019-06-15 20:04:24 UTC
The commit before, 5d8603f, is also needed for future-proofing when mercurial 5.1 comes around. The other commits are bug fixes and removal of compat code for old mercurial that we don't even carry in quarterly anymore.
Comment 3 Rene Ladan freebsd_committer 2020-01-27 20:08:19 UTC
Ping? Notice that this port expired today because it is Python-2.7-only, but has been retained for now.
Comment 4 Sunpoet Po-Chuan Hsieh freebsd_committer 2020-02-09 08:41:38 UTC
(In reply to Rene Ladan from comment #3)

All of its dependencies are python 2.7 only. That means this port is still python 2.7 only whether it's patched or not.
Comment 5 Rene Ladan freebsd_committer 2020-02-12 19:35:13 UTC
(In reply to Sunpoet Po-Chuan Hsieh from comment #4)
Hmm, indeed...
Comment 6 Rene Ladan freebsd_committer 2020-03-08 09:35:53 UTC
No feedback from maintainer (python@) in over a month, and the patch does not address upgrading the port to Python 3. Closing this PR.