Bug 238561 - sysutils/google-compute-engine-oslogin: Fix OSLogin
Summary: sysutils/google-compute-engine-oslogin: Fix OSLogin
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Larry Rosenman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-14 13:25 UTC by Lucas Kanashiro
Modified: 2019-06-14 13:55 UTC (History)
1 user (show)

See Also:


Attachments
fix OSLogin (4.22 KB, patch)
2019-06-14 13:25 UTC, Lucas Kanashiro
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Kanashiro 2019-06-14 13:25:05 UTC
Created attachment 205059 [details]
fix OSLogin

Larry Rosenman and Glen Barber from the FreeBSD team reported that the OSLogin feature has not been working since the last update I made to sysutils/google-compute-engine-oslogin ports package. I found out that the problem is in some modifications made by upstream in the shell script responsible to activate and deactivate the feature. I prepared the attached patch to fix it. With the patch applied in a FreeBSD 13 instance on GCE I was able to use the OSLogin feature without any problem. I also sent this same patch upstream.
Comment 1 commit-hook freebsd_committer 2019-06-14 13:51:01 UTC
A commit references this bug:

Author: ler
Date: Fri Jun 14 13:50:26 UTC 2019
New revision: 504192
URL: https://svnweb.freebsd.org/changeset/ports/504192

Log:
  sysutils/google-compute-engine-oslogin: fix OSLogin

  Larry Rosenman and Glen Barber from the FreeBSD team reported that the OSLogin
  feature has not been working since the last update I made to
  sysutils/google-compute-engine-oslogin ports package. I found out that the
  problem is in some modifications made by upstream in the shell script
  responsible to activate and deactivate the feature. I prepared the attached
  patch to fix it. With the patch applied in a FreeBSD 13 instance on GCE I was
  able to use the OSLogin feature without any problem. I also sent this same
  patch upstream.

  PR:		238561
  Submitted by:	lucas.kanashiro@collabora.com (maintainer)

Changes:
  head/sysutils/google-compute-engine-oslogin/Makefile
  head/sysutils/google-compute-engine-oslogin/files/
  head/sysutils/google-compute-engine-oslogin/files/patch-bin_google__oslogin__control
Comment 2 Larry Rosenman freebsd_committer 2019-06-14 13:55:31 UTC
Committed, Thanks!