Bug 238608 - devel/folly: fails to build on i386
Summary: devel/folly: fails to build on i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://github.com/facebook/folly/iss...
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2019-06-16 12:37 UTC by Jan Beich
Modified: 2019-06-16 17:56 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
poudriere log (135.50 KB, text/plain)
2019-06-16 12:37 UTC, Jan Beich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2019-06-16 12:37:44 UTC
Created attachment 205119 [details]
poudriere log

In file included from folly/stats/QuantileEstimator.cpp:17:
In file included from folly/stats/QuantileEstimator-defs.h:21:
folly/stats/detail/BufferedStat-defs.h:77:3: error: use of undeclared identifier 'DCHECK'
  DCHECK(g.owns_lock());
  ^
1 error generated.
Comment 1 Yuri Victorovich freebsd_committer 2019-06-16 17:56:12 UTC
Marked BROKEN on i386.
Comment 2 commit-hook freebsd_committer 2019-06-16 17:56:48 UTC
A commit references this bug:

Author: yuri
Date: Sun Jun 16 17:55:51 UTC 2019
New revision: 504359
URL: https://svnweb.freebsd.org/changeset/ports/504359

Log:
  devel/folly: Upstream patches; Fix bogus SYS_gettid-related code; Mark broken on i386

  PR:		238608
  Reported by:	jbeich (bogus SYS_gettid and i386 failure)

Changes:
  head/devel/folly/Makefile
  head/devel/folly/distinfo
  head/devel/folly/files/patch-folly_Memory.h
  head/devel/folly/files/patch-folly_Subprocess.cpp
  head/devel/folly/files/patch-folly_Subprocess.h
  head/devel/folly/files/patch-folly_experimental_EnvUtil.cpp
  head/devel/folly/files/patch-folly_portability_Malloc.h
  head/devel/folly/files/patch-folly_portability_Stdlib.cpp
  head/devel/folly/files/patch-folly_portability_SysSyscall.h