Bug 238620 - graphics/instant-meshes : include dirent.h instead of deprecated sys/dir.h
Summary: graphics/instant-meshes : include dirent.h instead of deprecated sys/dir.h
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks: 21519
  Show dependency tree / graph
 
Reported: 2019-06-16 15:32 UTC by Rene Ladan
Modified: 2019-06-17 16:57 UTC (History)
1 user (show)

See Also:
val: maintainer-feedback+

Attachments
update include files and USES (1.33 KB, patch)
2019-06-16 15:32 UTC, Rene Ladan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer freebsd_triage 2019-06-16 15:32:39 UTC 
Created attachment 205135 [details]
update include files and USES

Update this port to include dirent.h instead of sys/dir.h which is scheduled for removal. While here modernize USES.
Comment 1 Val Packett 2019-06-17 10:49:17 UTC 
LGTM.

Sent a PR upstream: https://github.com/wjakob/nanogui/pull/417
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2019-06-17 16:53:37 UTC 
Committed, thanks. Also a good idea to send it upstream :)
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-06-17 16:55:25 UTC 
A commit references this bug:

Author: rene
Date: Mon Jun 17 16:52:51 UTC 2019
New revision: 504430
URL: https://svnweb.freebsd.org/changeset/ports/504430

Log:
  graphics/instant-meshes: include dirent.h instead of sys/dir.h which is scheduled for removal.

  While here modernize USES

  PR:		238620
  Submitted by:	rene
  Approved by:	Greg V (maintainer)
  Event:		Berlin Hackathon 2019 (generating the patch)

Changes:
  head/graphics/instant-meshes/Makefile
  head/graphics/instant-meshes/files/patch-ext_nanogui_src_common.cpp
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-06-17 16:57:37 UTC 
A commit references this bug:

Author: rene
Date: Mon Jun 17 16:52:51 UTC 2019
New revision: 504430
URL: https://svnweb.freebsd.org/changeset/ports/504430

Log:
  graphics/instant-meshes: include dirent.h instead of sys/dir.h which is scheduled for removal.

  While here modernize USES

  PR:		238620
  Submitted by:	rene
  Approved by:	Greg V (maintainer)
  Event:		Berlin Hackathon 2019 (generating the patch)

Changes:
  head/graphics/instant-meshes/Makefile
  head/graphics/instant-meshes/files/patch-ext_nanogui_src_common.cpp