Bug 238659 - ocs_fc: print instance_index value rather than pointer itself in ocs_cam.c
Summary: ocs_fc: print instance_index value rather than pointer itself in ocs_cam.c
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-scsi (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-06-17 11:29 UTC by Fuqian
Modified: 2021-05-16 16:30 UTC (History)
1 user (show)

See Also:

Attachments
The patch file (1.21 KB, patch)
2019-06-17 11:29 UTC, Fuqian 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fuqian 2019-06-17 11:29:22 UTC 
Created attachment 205177 [details]
The patch file

In function ocs_scsi_recv_tmf, print instance_index rather than
the pointer itself to avoid printing out kernel pointer to user space.

 sys/dev/ocs_fc/ocs_cam.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/dev/ocs_fc/ocs_cam.c b/sys/dev/ocs_fc/ocs_cam.c
index 7efdc7a07ed..5de22d5f5f2 100644
--- a/sys/dev/ocs_fc/ocs_cam.c
+++ b/sys/dev/ocs_fc/ocs_cam.c
@@ -679,8 +679,8 @@ int32_t ocs_scsi_recv_tmf(ocs_io_t *tmfio, uint64_t lun, ocs_scsi_tmf_cmd_e cmd,
 		trsrc = &fcp->targ_rsrc_wildcard;
 	}
 
-	device_printf(tmfio->ocs->dev, "%s: io=%p cmd=%#x LU=%lx en=%s\n",
-			__func__, tmfio, cmd, (unsigned long)lun,
+	device_printf(tmfio->ocs->dev, "%s: io=%u(index) cmd=%#x LU=%lx en=%s\n",
+			__func__, tmfio->instance_index, cmd, (unsigned long)lun,
 			trsrc ? (trsrc->enabled ? "T" : "F") : "X");
 	if (trsrc) {
 		inot = (struct ccb_immediate_notify *)STAILQ_FIRST(&trsrc->inot);