Bug 238662 - mpt: replace mpt_prt with mpt_lprt in mpt_cam.c
Summary: mpt: replace mpt_prt with mpt_lprt in mpt_cam.c
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-scsi mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-06-17 11:32 UTC by Fuqian
Modified: 2019-07-04 10:42 UTC (History)
0 users

See Also:


Attachments
The patch file (2.42 KB, patch)
2019-06-17 11:32 UTC, Fuqian
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fuqian 2019-06-17 11:32:19 UTC
Created attachment 205180 [details]
The patch file

Replace mpt_prt with mpt_lprt with DEBUG level to
print kernel pointers in a certain debug level.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
 sys/dev/mpt/mpt_cam.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/sys/dev/mpt/mpt_cam.c b/sys/dev/mpt/mpt_cam.c
index 4fbca1d9fe2..1083e083a82 100644
--- a/sys/dev/mpt/mpt_cam.c
+++ b/sys/dev/mpt/mpt_cam.c
@@ -1249,7 +1249,8 @@ mpt_timeout(void *arg)
 
 	MPT_LOCK_ASSERT(mpt);
 	req = ccb->ccb_h.ccb_req_ptr;
-	mpt_prt(mpt, "request %p:%u timed out for ccb %p (req->ccb %p)\n", req,
+	mpt_lprt(mpt, MPT_PRT_DEBUG,
+	"request %p:%u timed out for ccb %p (req->ccb %p)\n", req,
 	    req->serno, ccb, req->ccb);
 /* XXX: WHAT ARE WE TRYING TO DO HERE? */
 	if ((req->state & REQ_STATE_QUEUED) == REQ_STATE_QUEUED) {
@@ -2598,7 +2599,8 @@ mpt_scsi_reply_handler(struct mpt_softc *mpt, request_t *req,
 	scsi_req = (MSG_SCSI_IO_REQUEST *)req->req_vbuf;
 	ccb = req->ccb;
 	if (ccb == NULL) {
-		mpt_prt(mpt, "mpt_scsi_reply_handler: req %p:%u with no ccb\n",
+		mpt_lprt(mpt, MPT_PRT_DEBUG,
+		"mpt_scsi_reply_handler: req %p:%u with no ccb\n",
 		    req, req->serno);
 		return (TRUE);
 	}
@@ -2655,7 +2657,8 @@ mpt_scsi_reply_handler(struct mpt_softc *mpt, request_t *req,
 	if ((req->state & REQ_STATE_TIMEDOUT) == 0) {
 		TAILQ_REMOVE(&mpt->request_pending_list, req, links);
 	} else {
-		mpt_prt(mpt, "completing timedout/aborted req %p:%u\n",
+		mpt_lprt(mpt, MPT_PRT_DEBUG,
+		"completing timedout/aborted req %p:%u\n",
 		    req, req->serno);
 		TAILQ_REMOVE(&mpt->request_timeout_list, req, links);
 	}
@@ -4017,7 +4020,8 @@ mpt_recover_commands(struct mpt_softc *mpt)
 		uint8_t response;
 		MSG_REQUEST_HEADER *hdrp = req->req_vbuf;
 
-		mpt_prt(mpt, "attempting to abort req %p:%u function %x\n",
+		mpt_lprt(mpt, MPT_PRT_DEBUG,
+		"attempting to abort req %p:%u function %x\n",
 		    req, req->serno, hdrp->Function);
 		ccb = req->ccb;
 		if (ccb == NULL) {
@@ -4092,7 +4096,8 @@ mpt_recover_commands(struct mpt_softc *mpt)
 			mpt_reset(mpt, TRUE);
 			continue;
 		}
-		mpt_prt(mpt, "abort of req %p:%u completed\n", req, req->serno);
+		mpt_lprt(mpt, MPT_PRT_DEBUG,
+		"abort of req %p:%u completed\n", req, req->serno);
 	}
 }