Created attachment 205180 [details] The patch file Replace mpt_prt with mpt_lprt with DEBUG level to print kernel pointers in a certain debug level. Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com> --- sys/dev/mpt/mpt_cam.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/sys/dev/mpt/mpt_cam.c b/sys/dev/mpt/mpt_cam.c index 4fbca1d9fe2..1083e083a82 100644 --- a/sys/dev/mpt/mpt_cam.c +++ b/sys/dev/mpt/mpt_cam.c @@ -1249,7 +1249,8 @@ mpt_timeout(void *arg) MPT_LOCK_ASSERT(mpt); req = ccb->ccb_h.ccb_req_ptr; - mpt_prt(mpt, "request %p:%u timed out for ccb %p (req->ccb %p)\n", req, + mpt_lprt(mpt, MPT_PRT_DEBUG, + "request %p:%u timed out for ccb %p (req->ccb %p)\n", req, req->serno, ccb, req->ccb); /* XXX: WHAT ARE WE TRYING TO DO HERE? */ if ((req->state & REQ_STATE_QUEUED) == REQ_STATE_QUEUED) { @@ -2598,7 +2599,8 @@ mpt_scsi_reply_handler(struct mpt_softc *mpt, request_t *req, scsi_req = (MSG_SCSI_IO_REQUEST *)req->req_vbuf; ccb = req->ccb; if (ccb == NULL) { - mpt_prt(mpt, "mpt_scsi_reply_handler: req %p:%u with no ccb\n", + mpt_lprt(mpt, MPT_PRT_DEBUG, + "mpt_scsi_reply_handler: req %p:%u with no ccb\n", req, req->serno); return (TRUE); } @@ -2655,7 +2657,8 @@ mpt_scsi_reply_handler(struct mpt_softc *mpt, request_t *req, if ((req->state & REQ_STATE_TIMEDOUT) == 0) { TAILQ_REMOVE(&mpt->request_pending_list, req, links); } else { - mpt_prt(mpt, "completing timedout/aborted req %p:%u\n", + mpt_lprt(mpt, MPT_PRT_DEBUG, + "completing timedout/aborted req %p:%u\n", req, req->serno); TAILQ_REMOVE(&mpt->request_timeout_list, req, links); } @@ -4017,7 +4020,8 @@ mpt_recover_commands(struct mpt_softc *mpt) uint8_t response; MSG_REQUEST_HEADER *hdrp = req->req_vbuf; - mpt_prt(mpt, "attempting to abort req %p:%u function %x\n", + mpt_lprt(mpt, MPT_PRT_DEBUG, + "attempting to abort req %p:%u function %x\n", req, req->serno, hdrp->Function); ccb = req->ccb; if (ccb == NULL) { @@ -4092,7 +4096,8 @@ mpt_recover_commands(struct mpt_softc *mpt) mpt_reset(mpt, TRUE); continue; } - mpt_prt(mpt, "abort of req %p:%u completed\n", req, req->serno); + mpt_lprt(mpt, MPT_PRT_DEBUG, + "abort of req %p:%u completed\n", req, req->serno); } }
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=5b900bd26ab46dfb1a6889d593de3f2e50f4ad35 commit 5b900bd26ab46dfb1a6889d593de3f2e50f4ad35 Author: Fuqian Huang <huangfq.daxian@gmail.com> AuthorDate: 2019-06-17 10:55:00 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2025-02-05 00:47:21 +0000 mpt: replace mpt_prt with mpt_lprt in mpt_cam.c Replace mpt_prt with mpt_lprt with DEBUG level to print kernel pointers only at the debug level. PR: 238662 Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com> Reviewed-by: imp sys/dev/mpt/mpt_cam.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
no mfc planned