Bug 238671 - sysutils/node_exporter: Update to 0.18.1
Summary: sysutils/node_exporter: Update to 0.18.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-17 21:25 UTC by David O'Rourke
Modified: 2019-06-20 11:25 UTC (History)
3 users (show)

See Also:
ports: maintainer-feedback+


Attachments
sysutils/node_exporter: Update to 0.18.1 (1.02 KB, patch)
2019-06-17 21:25 UTC, David O'Rourke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David O'Rourke 2019-06-17 21:25:32 UTC
Created attachment 205189 [details]
sysutils/node_exporter: Update to 0.18.1

This patch updates sysutils/node_exporter to 0.18.1, a minor bugfix release with two fixed issues.

 - Fix incorrect sysctl call in BSD meminfo collector, resulting in broken swap metrics on FreeBSD
 - Fix rollover bug in mountstats collector

The patch passes poudriere testport.

-David
Comment 1 Thomas Steen Rasmussen / Tykling 2019-06-20 10:04:58 UTC
node_exporter 0.18.0 spams messages every 15 seconds with the following error:

Jun 20 10:01:31 svaneke node_exporter[80549]: time="2019-06-20T10:01:31Z" level=error msg="ERROR: meminfo collector failed after 0.000104s: couldn't get memory: no such file or directory" source="collector.go:132"                                              
Jun 20 10:01:46 svaneke node_exporter[80549]: time="2019-06-20T10:01:46Z" level=error msg="ERROR: meminfo collector failed after 0.000128s: couldn't get memory: no such file or directory" source="collector.go:132"                                              
Jun 20 10:02:01 svaneke node_exporter[80549]: time="2019-06-20T10:02:01Z" level=error msg="ERROR: meminfo collector failed after 0.000098s: couldn't get memory: no such file or directory" source="collector.go:132"                                              
Jun 20 10:02:16 svaneke node_exporter[80549]: time="2019-06-20T10:02:16Z" level=error msg="ERROR: meminfo collector failed after 0.000109s: couldn't get memory: no such file or directory" source="collector.go:132"                                              
Jun 20 10:02:32 svaneke node_exporter[80549]: time="2019-06-20T10:02:32Z" level=error msg="ERROR: meminfo collector failed after 0.000078s: couldn't get memory: no such file or directory" source="collector.go:132"                                              
Jun 20 10:02:46 svaneke node_exporter[80549]: time="2019-06-20T10:02:46Z" level=error msg="ERROR: meminfo collector failed after 0.000108s: couldn't get memory: no such file or directory" source="collector.go:132"                                              
Jun 20 10:03:01 svaneke node_exporter[80549]: time="2019-06-20T10:03:01Z" level=error msg="ERROR: meminfo collector failed after 0.000118s: couldn't get memory: no such file or directory" source="collector.go:132"                                              
Jun 20 10:03:16 svaneke node_exporter[80549]: time="2019-06-20T10:03:16Z" level=error msg="ERROR: meminfo collector failed after 0.000079s: couldn't get memory: no such file or directory" source="collector.go:132"

Getting node_exporter upgraded to 0.18.1 fixes this. Hoping these log entries can make this easy to find from search engines for the future.
Comment 2 commit-hook freebsd_committer 2019-06-20 11:25:28 UTC
A commit references this bug:

Author: swills
Date: Thu Jun 20 11:24:50 UTC 2019
New revision: 504626
URL: https://svnweb.freebsd.org/changeset/ports/504626

Log:
  sysutils/node_exporter: Update to 0.18.1

  PR:		238671
  Submitted by:	David O'Rourke <dor.bsd@xm0.uk>
  Approved by:	jevonearth <ports@ecadlabs.com> (maintainer)

Changes:
  head/sysutils/node_exporter/Makefile
  head/sysutils/node_exporter/distinfo
Comment 3 Steve Wills freebsd_committer 2019-06-20 11:25:55 UTC
Committed, thanks!