Bug 238718 - science/py-scikit-learn : Update to 0.21.2
Summary: science/py-scikit-learn : Update to 0.21.2
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-20 07:33 UTC by wen
Modified: 2019-11-11 12:02 UTC (History)
2 users (show)

See Also:
demon: maintainer-feedback+


Attachments
update to 0.21.2 (1.31 KB, text/plain)
2019-06-20 07:33 UTC, wen
no flags Details
Update to 0.21.3 (1.41 KB, patch)
2019-11-07 18:42 UTC, geraud
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description wen 2019-06-20 07:33:45 UTC
Created attachment 205229 [details]
update to 0.21.2

- Update to 0.21.2
Comment 1 Dmitry Sivachenko freebsd_committer 2019-06-20 08:56:36 UTC
-LDFLAGS+=      -shared
+#LDFLAGS+=     -shared

Is this something you forgot?  Why do you keep this line commented (uncomment or delete?)

Other than that your patch looks good.

Feel free to take maintainership of this port if you with.
Comment 2 Dmitry Sivachenko freebsd_committer 2019-06-20 08:57:34 UTC
"if you WISH" ^^
Comment 3 wen 2019-06-20 22:43:11 UTC
(In reply to Dmitry Sivachenko from comment #1)
The build failed with the line LDFLAGS+=-shared.

wen
Comment 4 wen 2019-06-20 22:43:28 UTC
(In reply to Dmitry Sivachenko from comment #2)
Thank you !
Comment 5 geraud 2019-11-07 18:42:45 UTC
Created attachment 208947 [details]
Update to 0.21.3

Here's my take on the update (based on wen's previous patch) :

- Bump to the latest stable (0.21.3)
- Remove cblas dependency (it now uses numpy's BLAS option)
- Add py-joblib dependency

Let me know if changes are needed.
Comment 6 Dmitry Sivachenko freebsd_committer 2019-11-11 12:02:01 UTC
Wen, 

can you please look at it?

I do not use this software anymore.

I released maintainership, so you can take it if you wish.

Thanks.