Bug 238719 - devel/hs-git-annex: The wrapper script doesn't support file names with spaces
Summary: devel/hs-git-annex: The wrapper script doesn't support file names with spaces
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-haskell mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-20 10:22 UTC by crest
Modified: 2019-06-20 16:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (haskell)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description crest 2019-06-20 10:22:36 UTC
The wrapper script installed into /usr/local/bin/git-annex uses $* instead of "$@". Because of this it splits arguments that shouldn't be split braking among other things all operations on filenames with spaces in them e.g. `git annex get foo\ bar.txt`.
Comment 1 commit-hook freebsd_committer 2019-06-20 16:04:07 UTC
A commit references this bug:

Author: arrowd
Date: Thu Jun 20 16:03:17 UTC 2019
New revision: 504637
URL: https://svnweb.freebsd.org/changeset/ports/504637

Log:
  In wrapper scripts, use $@ instead of $* to correctly pass arguments to the real program

  PR:		238719
  Approved by:	tcberner (mentor, implicit)

Changes:
  head/Mk/Uses/cabal.mk
  head/converters/hs-aeson-pretty/Makefile
  head/devel/hs-ShellCheck/Makefile
  head/devel/hs-alex/Makefile
  head/devel/hs-bytestring-nums/Makefile
  head/devel/hs-c2hs/Makefile
  head/devel/hs-cabal-install/Makefile
  head/devel/hs-cpphs/Makefile
  head/devel/hs-darcs/Makefile
  head/devel/hs-ghc-events/Makefile
  head/devel/hs-git-annex/Makefile
  head/devel/hs-haddock/Makefile
  head/devel/hs-happy/Makefile
  head/devel/hs-hasktags/Makefile
  head/devel/hs-hlint/Makefile
  head/devel/hs-hoogle/Makefile
  head/devel/hs-hspec-discover/Makefile
  head/devel/hs-mueval/Makefile
  head/devel/hs-shake/Makefile
  head/devel/hs-threadscope/Makefile
  head/devel/stack/Makefile
  head/games/hedgewars-server/Makefile
  head/games/hs-scroll/Makefile
  head/lang/hs-brainfuck/Makefile
  head/lang/hs-unlambda/Makefile
  head/print/hs-hscolour/Makefile
  head/textproc/cgrep/Makefile
  head/textproc/hs-lhs2tex/Makefile
  head/textproc/hs-pandoc/Makefile
  head/textproc/hs-pandoc-citeproc/Makefile
  head/textproc/hs-yaml/Makefile
  head/www/hs-DAV/Makefile
  head/www/hs-hjsmin/Makefile
  head/www/hs-wai-app-static/Makefile
  head/www/hs-yesod-bin/Makefile
  head/x11/hs-xmobar/Makefile
Comment 2 Gleb Popov freebsd_committer 2019-06-20 16:06:02 UTC
Thanks for pointing this out. Should be fixed now.