Bug 238756 - security/keepassxc: Update to 2.4.3
Summary: security/keepassxc: Update to 2.4.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: https://github.com/keepassxreboot/kee...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-06-22 03:20 UTC by Tobias Kortkamp
Modified: 2019-06-22 22:06 UTC (History)
1 user (show)

See Also:
melanhit: maintainer-feedback+


Attachments
keepassxc.diff (13.19 KB, patch)
2019-06-22 03:20 UTC, Tobias Kortkamp
no flags Details | Diff
keepassxc.diff (2.91 KB, patch)
2019-06-22 17:39 UTC, Tobias Kortkamp
tobik: maintainer-approval? (melanhit)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2019-06-22 03:20:23 UTC
Created attachment 205275 [details]
keepassxc.diff

- Update to 1.4.3
- Explicitly disable update checking as per upstream's recommendation
  for downstream packagers.
- Clean up unused libcurl dependency too
- Enable YUBIKEY by default
- It required some patching to even build. I sent that upstream and also
  took the opportunity to include other port local patches there too [1].

[1] https://github.com/keepassxreboot/keepassxc/pull/3304

Poudriere test builds were fine on 11.2/i386 and 12.0/amd64
Local build on 13.0/amd64 was fine too.

----

security/keepassxc: Update to 1.4.3

Changes:	https://github.com/keepassxreboot/keepassxc/releases
PR:		???????
Approved by:	melanhit@gmail.com (maintainer) ???
Comment 1 Tobias Kortkamp freebsd_committer 2019-06-22 03:21:27 UTC
Hmm, no. I meant 2.4.3 of course :-)
Comment 2 Tobias Kortkamp freebsd_committer 2019-06-22 17:39:11 UTC
Created attachment 205282 [details]
keepassxc.diff

- Upstream pull request has been merged.  Use the relevant commit directly
  instead of adding a patch file to the tree.
Comment 3 Andrew Romanenko 2019-06-22 21:50:03 UTC
thanks
Comment 4 commit-hook freebsd_committer 2019-06-22 22:05:52 UTC
A commit references this bug:

Author: tobik
Date: Sat Jun 22 22:05:12 UTC 2019
New revision: 504913
URL: https://svnweb.freebsd.org/changeset/ports/504913

Log:
  security/keepassxc: Update to 2.4.3

  - Drop patch and workarounds and use the fixes I sent upstream
    instead
  - Remove no longer needed libcurl dependency
  - Disable useless update check.  Upstream also recommends to do this
    for OS packages.
  - Enable YUBIKEY option by default

  Changes:	https://github.com/keepassxreboot/keepassxc/releases
  PR:		238756
  Submitted by:	tobik
  Approved by:	melanhit@gmail.com (maintainer)

Changes:
  head/security/keepassxc/Makefile
  head/security/keepassxc/distinfo
Comment 5 Tobias Kortkamp freebsd_committer 2019-06-22 22:06:49 UTC
Committed, thanks.