Bug 238879 - mail/milter-regex: Postfix not allowed to use socket
Summary: mail/milter-regex: Postfix not allowed to use socket
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2019-06-29 15:34 UTC by John W. O'Brien
Modified: 2019-07-11 18:00 UTC (History)
2 users (show)

See Also:


Attachments
mail/milter-regex: Make socket compatible with Postfix (3.71 KB, text/plain)
2019-06-29 15:34 UTC, John W. O'Brien
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John W. O'Brien 2019-06-29 15:34:26 UTC
Created attachment 205413 [details]
mail/milter-regex: Make socket compatible with Postfix

The socket milter-regex creates by default is root:mail 0600, which Postfix cannot use. The effect of a previous patch which has since been upstreamed has evidently been undone by other changes.

This patch changes the default socket ownership and permissions, and exposes the G P and U options via rc.conf.

While here, convert pkg-message to UCL and make minor enhancements.

QA
==

portlint: OK
poudriere: OK -- testport on 11.2R amd64
Comment 1 Dirk Meyer freebsd_committer 2019-07-09 07:45:37 UTC
Setting "milterregex_flags" is sufficient to set non default permissions.

I reject the UCL part of this patch.
Comment 2 John W. O'Brien 2019-07-10 02:21:13 UTC
(In reply to Dirk Meyer from comment #1)
It is not clear where we stand. You indicated your approval with maintainer feedback "+" and expressed your rejection of my patch.
Comment 3 Dirk Meyer freebsd_committer 2019-07-11 17:39:31 UTC
(In reply to John W. O'Brien from comment #2)

if you hoover over it you see it explained:

MAINTAINER feedback:

Can mean want/needs/has/no feedback from MAINTAINER:
* Set (?) <maintainer-email> to request MAINTAINER feedback
* Set (+) when you provide feedback. Avoids 'maintainer timeout'
* Set (-) when feedback is not provided. Add comment. Use for 'maintainer timeout'
Comment 4 Dirk Meyer freebsd_committer 2019-07-11 18:00:46 UTC
Issues:

1)
Your patch removed the default for enable,
and the script creates a warning:

milterregex: WARNING: $milterregex_enable is not set properly - see rc.conf(5).

2)
Your patch moves the defaults from the binary into the command line of the process. This clogs the process views.

POLA: We should not have different defaults without reason from the code and from the port.

3)
The UCL format of pkg-message makes it hard to read for humans

I can't accept the patch in this state.