Bug 238886 - games/leela-zero: don't set -march=native
Summary: games/leela-zero: don't set -march=native
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-29 21:42 UTC by Piotr Kubaj
Modified: 2019-06-30 19:45 UTC (History)
2 users (show)

See Also:
yuri: maintainer-feedback+
koobs: merge-quarterly?


Attachments
patch (764 bytes, patch)
2019-06-29 21:42 UTC, Piotr Kubaj
yuri: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-06-29 21:42:13 UTC
Created attachment 205424 [details]
patch

-march=native breaks compilation on powerpc64 and we shouldn't optimize anyway for the CPU in the build cluster.
Comment 1 Yuri Victorovich freebsd_committer 2019-06-29 21:57:14 UTC
Approved.
Comment 2 commit-hook freebsd_committer 2019-06-30 19:45:40 UTC
A commit references this bug:

Author: pkubaj
Date: Sun Jun 30 19:44:36 UTC 2019
New revision: 505453
URL: https://svnweb.freebsd.org/changeset/ports/505453

Log:
  games/leela-zero: don't set -march=native

  -march=native breaks compilation on powerpc64 and we shouldn't optimize anyway for the CPU in the build cluster.

  PR:             238886
  Approved by:    yuri (maintainer), tcberner (mentor)
  Differential Revision:  https://reviews.freebsd.org/D20806

Changes:
  head/games/leela-zero/Makefile
  head/games/leela-zero/files/patch-CMakeLists.txt