Created attachment 205425 [details] patch Upstream commit has removed -Werror outside of developer mode. Backport that commit to fix build when using GCC.
Maintainer informed via mail
Reporter is committer, assign accordingly @Piotr -Werror should be patched out here too (it shouldn't be used/enabled in packaged/distributed/released code. setup.py does the following: DEVELOPER_MODE = os.path.exists(os.path.join(basedir, 'MANIFEST.in')) if DEVELOPER_MODE: print('found MANIFEST.in, running in developer mode') <snip> compile_args.append('-Werror') compile_args.append('-Wfatal-errors') The conditional for DEVELOPER_MODE is too widely-scoped, as source distributions (sdists) are released to end-users, and the presence of a MANIFEST.in shouldn't mean DEVELOPER_MODE. A slightly better form might be to check for the presence of a git checkout, though this is also problematic, as users can depend on packages via their git URL's. The check should probably be an explicit opt-in via the presence of an environment variable DEVELOPER_MODE=yes or similar. Either way, I'd patch the conditional to be False, along with the patch provided fixing the warning. If you can, please report this '-Werror should be opt-in, not based on MANIFEST.in' issue upstream, with a PR if you can manage it Note also, both the build (warning=error) fix, and the -Werror removal are: Approved by: portmgr (blanket(s): build fix, ports compliance)
A commit references this bug: Author: pkubaj Date: Tue Jul 30 12:43:05 UTC 2019 New revision: 507639 URL: https://svnweb.freebsd.org/changeset/ports/507639 Log: devel/py-llfuse: Fix build (warning=error), remove -Werror -Werror is added to flags by default, breaking build for example with GCC. Follow upstream and remove it. Also disable DEVELOPER_MODE since it's enabled too widely. PR: 238887 Approved by: portmgr (blanket(s): build fix, ports compliance), linimon (mentor) Differential Revision: https://reviews.freebsd.org/D21067 Changes: head/devel/py-llfuse/Makefile head/devel/py-llfuse/files/files/ head/devel/py-llfuse/files/files/patch-setup.py head/devel/py-llfuse/files/patch-setup.py
@Piotr Is quarterly affected? If so, please MFH. If not, set merge-quarterly to - and close Thanks!
(In reply to Kubilay Kocak from comment #4) MFH'd.
A commit references this bug: Author: pkubaj Date: Sat Aug 3 19:28:53 UTC 2019 New revision: 507990 URL: https://svnweb.freebsd.org/changeset/ports/507990 Log: MFH: r507639 devel/py-llfuse: Fix build (warning=error), remove -Werror -Werror is added to flags by default, breaking build for example with GCC. Follow upstream and remove it. Also disable DEVELOPER_MODE since it's enabled too widely. PR: 238887 Approved by: portmgr (blanket(s): build fix, ports compliance), linimon (mentor) Differential Revision: https://reviews.freebsd.org/D21067 Changes: _U branches/2019Q3/ branches/2019Q3/devel/py-llfuse/Makefile branches/2019Q3/devel/py-llfuse/files/files/ branches/2019Q3/devel/py-llfuse/files/patch-setup.py