Bug 238982 - [PATCH] math/scilab: Support for Java version changes
Summary: [PATCH] math/scilab: Support for Java version changes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks: 238758
  Show dependency treegraph
 
Reported: 2019-07-04 02:46 UTC by Greg Lewis
Modified: 2019-07-07 23:14 UTC (History)
0 users

See Also:
makc: maintainer-feedback+
glewis: maintainer-feedback?


Attachments
Makefile changes (370 bytes, patch)
2019-07-04 02:46 UTC, Greg Lewis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Lewis freebsd_committer 2019-07-04 02:46:05 UTC
Created attachment 205515 [details]
Makefile changes

In bug #238758 I have a change that will alter the format of JAVA_PORT_VERSION to be consistent with modern Java versioning.  This patch adds support to this port for handling that, while preserving the functionality with the current format of JAVA_PORT_VERSION.  Please review.
Comment 1 Max Brazhnikov freebsd_committer 2019-07-07 08:31:57 UTC
Looks fine, thanks!
Comment 2 commit-hook freebsd_committer 2019-07-07 23:13:27 UTC
A commit references this bug:

Author: glewis
Date: Sun Jul  7 23:13:21 UTC 2019
New revision: 506198
URL: https://svnweb.freebsd.org/changeset/ports/506198

Log:
  Adjust to proposed changes in Java versioning

  * Bug #238758 proposes to change the Java versioning from versions such
    as "1.6.0" to versions such as "6" (for example).  Modify the Makefile
    checks on JAVA_PORT_VERSION to cope with either format.

  PR:		238982
  Approved by:	makc (maintainer)

Changes:
  head/math/scilab/Makefile
Comment 3 Greg Lewis freebsd_committer 2019-07-07 23:14:39 UTC
Thanks!