Created attachment 205669 [details] proposed fix For FreeBSD 11.3-STABLE (r349872): # cd /usr/src/sys/modules/spi # make ===> sys/modules/spi (all) ===> sys/modules/spi/../spigen (all) machine -> /usr/src/sys/amd64/include x86 -> /usr/src/sys/x86/include awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/bus_if.m -h awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/device_if.m -h :> opt_platform.h awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/dev/spibus/spibus_if.m -h cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I. -I/usr/src/sys - fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD -MF.depend.spigen.o -MTspig en.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototyp es -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__ =__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-err or-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-fun ction -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-error-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999 -c /usr/src/sys/dev/spibus/spigen.c -o spigen.o /usr/src/sys/dev/spibus/spigen.c:29:10: fatal error: 'opt_spi.h' file not found #include "opt_spi.h" ^~~~~~~~~~~ 1 error generated. *** Error code 1
Looks correct to me (I remember fixing something similar for pf). I think you can just commit this.
Are you not a src committer? Why all the overhead of a bug report for a 1-line fix you could commit in 15 seconds and get on with real work?
A commit references this bug: Author: eugen Date: Tue Jul 16 19:40:23 UTC 2019 New revision: 350066 URL: https://svnweb.freebsd.org/changeset/base/350066 Log: MFC r336561 by lwhsu: Fix `make` in sys/modules/spigen PR: 239119 Changes: _U stable/11/ stable/11/sys/modules/spigen/Makefile
Fix merged.