Bug 239154 - lang/go14: fix shebangs after update to go1.4-bootstrap-20171003
Summary: lang/go14: fix shebangs after update to go1.4-bootstrap-20171003
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Julien Laffaye
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-12 04:14 UTC by John Hein
Modified: 2019-07-16 15:09 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (jlaffaye)


Attachments
[patch] fix g014 shebangs for bash scripts (443 bytes, patch)
2019-07-12 04:14 UTC, John Hein
jcfyecrayz: maintainer-approval? (jlaffaye)
Details | Diff
patch file (10.55 KB, patch)
2019-07-16 15:09 UTC, Dmitri Goutnik
dg: maintainer-approval? (jlaffaye)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2019-07-12 04:14:14 UTC
Created attachment 205710 [details]
[patch] fix g014 shebangs for bash scripts

'make -C /usr/ports/lang/go14 stage-qa' gives this error:

Error: '/bin/bash' is an invalid shebang you need USES=shebangfix for 'go14/misc/makerelease/darwin/scripts/postinstall'
Error: '/bin/bash' is an invalid shebang you need USES=shebangfix for 'go14/misc/makerelease/darwin/scripts/preinstall'


The attached patch fixes it.  One could also develop a patch to skip installing the files as I believe they probably aren't needed for the freebsd port.  But this patch seemed easy and the files involved are tiny, so removing them from the package doesn't save (much) space.
Comment 1 Dmitri Goutnik 2019-07-16 15:09:02 UTC
Created attachment 205820 [details]
patch file

An extended version of the patch that

- Fixes QA errors
- Trims stuff not needed for building/testing or lang/go bootstrapping 
- Fixes test target

Passes poudriere testport on 120a, 120i, 112a