Bug 239162 - consolidate arch definitions in graphics/libdrm
Summary: consolidate arch definitions in graphics/libdrm
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 mailing list
Depends on:
Reported: 2019-07-12 16:03 UTC by Mark Linimon
Modified: 2019-07-12 21:04 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (x11)

patch to graphics/libdrm/Makefile (770 bytes, patch)
2019-07-12 16:03 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2019-07-12 16:03:16 UTC
Created attachment 205718 [details]
patch to graphics/libdrm/Makefile

In various places in the ports tree, tests against ARCH are iterated one-by-one when a pattern test would be more robust.

This consolidates the tests for arm and powerpc, and in the process, possibly fixes powerpcspe.  (While the latter is possibly a null case, I am trying to create a consistent usage across the tree.)
Comment 1 commit-hook freebsd_committer 2019-07-12 21:02:54 UTC
A commit references this bug:

Author: zeising
Date: Fri Jul 12 21:01:50 UTC 2019
New revision: 506490
URL: https://svnweb.freebsd.org/changeset/ports/506490

  graphics/libdrm: Fix check for arm and powerpc

  Fix the theck for arm and powerpc in graphics/libdrm Makefile.  Instead of
  checking for specific powerpc or arm versions, just use a pattern check for
  powerpc* and arm* respectively.

  This is part of a bigger sweep to consolodate this throughout the ports

  PR:		239162
  Submitted by:	linimon

Comment 2 Niclas Zeising freebsd_committer 2019-07-12 21:04:03 UTC
Committed, thanks!